Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 139040043: code review 139040043: runtime: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
iant
CC:
golang-codereviews
Visibility:
Public.

Description

runtime: fix windows build #ifdef'ed out code wasn't updated for argp change.

Patch Set 1 #

Patch Set 2 : diff -r 7844c28fa2952f205ee365c89a213bb0c1627528 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7844c28fa2952f205ee365c89a213bb0c1627528 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/traceback_x86.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2014-09-01 21:36:40 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=5859e2509c96 *** runtime: fix windows build #ifdef'ed out code wasn't updated for ...
10 years, 6 months ago (2014-09-01 21:36:47 UTC) #2
iant
10 years, 6 months ago (2014-09-02 13:58:13 UTC) #3
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b