Issue 138980043: code review 138980043: runtime: change PC, SP values in Stkframe, Panic, Defer...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 138980043: code review 138980043: runtime: change PC, SP values in Stkframe, Panic, Defer... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rsc

Modified:
11 years, 3 months ago

Reviewers:
r, gobot

CC:
golang-codereviews, r, iant, khr

Visibility:
Public.

Description

runtime: change PC, SP values in Stkframe, Panic, Defer from byte* to uintptr uintptr is better when translating to Go, and in a few places it's better in C too.

Patch Set 1 #

Patch Set 2 : diff -r ff82d3107ab32b2cd28e252205835fd544885791 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ff82d3107ab32b2cd28e252205835fd544885791 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 4085766e83907da960acf906f483372e1cce7130 https://code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -50 lines)			Patch
M	src/pkg/runtime/heapdump.c	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/mgc0.c	View	1	5 chunks	+10 lines, -10 lines	0 comments	Download
M	src/pkg/runtime/panic.c	View	1 2	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pkg/runtime/stack.c	View	1 2	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/traceback_arm.c	View	1 2	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/traceback_x86.c	View	1 2	3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, khr, r), I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2014-09-01 04:01:56 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=c54b847a8ea3 *** runtime: change PC, SP values in Stkframe, Panic, Defer from ...

11 years, 3 months ago (2014-09-01 14:05:21 UTC) #3

gobot

11 years, 3 months ago (2014-09-01 14:17:47 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/2947dc2a9f94a860fd757e6caeb3d98154c746be

Expand All Messages | Collapse All Messages