Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(261)

Issue 13891043: code review 13891043: doc: document installation of go.tools commands (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by adg
Modified:
11 years, 7 months ago
CC:
golang-dev
Visibility:
Public.

Description

doc: document installation of go.tools commands Fixes issue 5663.

Patch Set 1 #

Total comments: 10

Patch Set 2 : diff -r e501600df820 https://code.google.com/p/go #

Total comments: 3

Patch Set 3 : diff -r 3a322810a773 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M doc/install-source.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 7 months ago (2013-09-25 03:49:08 UTC) #1
r
https://codereview.appspot.com/13891043/diff/1/doc/install-source.html File doc/install-source.html (right): https://codereview.appspot.com/13891043/diff/1/doc/install-source.html#newcode226 doc/install-source.html:226: Various Go tools (including <a href="/cmd/godoc/">godoc</a>) The source code ...
11 years, 7 months ago (2013-09-25 03:55:27 UTC) #2
adg
PTAL https://codereview.appspot.com/13891043/diff/1/doc/install-source.html File doc/install-source.html (right): https://codereview.appspot.com/13891043/diff/1/doc/install-source.html#newcode226 doc/install-source.html:226: Various Go tools (including <a href="/cmd/godoc/">godoc</a>) On 2013/09/25 ...
11 years, 7 months ago (2013-09-25 04:01:48 UTC) #3
r
LGTM https://codereview.appspot.com/13891043/diff/6001/doc/install-source.html File doc/install-source.html (right): https://codereview.appspot.com/13891043/diff/6001/doc/install-source.html#newcode244 doc/install-source.html:244: present on your system to check out code ...
11 years, 7 months ago (2013-09-25 04:04:53 UTC) #4
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=78fe414819a1 *** doc: document installation of go.tools commands Fixes issue 5663. R=golang-dev, ...
11 years, 7 months ago (2013-09-25 04:10:58 UTC) #5
minux1
do we also need to note that godoc will be installed to $GOROOT/bin and vet ...
11 years, 7 months ago (2013-09-25 04:11:22 UTC) #6
satish.puranam
there a small typo s/seeral/several https://codereview.appspot.com/13891043/diff/6001/doc/install-source.html File doc/install-source.html (right): https://codereview.appspot.com/13891043/diff/6001/doc/install-source.html#newcode226 doc/install-source.html:226: The source code for ...
11 years, 7 months ago (2013-09-25 04:12:01 UTC) #7
adg
11 years, 7 months ago (2013-09-25 04:14:24 UTC) #8
On 25 September 2013 14:11, <minux.ma@gmail.com> wrote:

> do we also need to note that godoc will be installed to $GOROOT/bin and
> vet to $GOROOT/pkg/tool/$GOOS_$**GOARCH/?
> (this fact is also contained in doc/go1.2.html)
>

You're right, that will be confusing, particularly for vet and cover which
will only be accessible as "go tool vet" etc.

I'll send another CL>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b