Issue 138860043: code review 138860043: image/png: make the CompressionLevel constants negative...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 138860043: code review 138860043: image/png: make the CompressionLevel constants negative... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by nigeltao

Modified:
9 years, 8 months ago

Reviewers:
ruiu, gobot, bradfitz

CC:
bradfitz, ruiu, golang-codereviews, jeff.allen

Visibility:
Public.

Description

image/png: make the CompressionLevel constants negative, reserving positive numbers to mean a numeric zlib compression level.

Patch Set 1 #

Patch Set 2 : diff -r c37fc54f7e208062baa619ecc43197dff1448a2c https://code.google.com/p/go/ #

Patch Set 3 : diff -r c37fc54f7e208062baa619ecc43197dff1448a2c https://code.google.com/p/go/ #

Patch Set 4 : diff -r c37fc54f7e208062baa619ecc43197dff1448a2c https://code.google.com/p/go/ #

Patch Set 5 : diff -r 488318c7946f0228d6df3010272c7152eb3386df https://code.google.com/p/go/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	src/pkg/image/png/writer.go	View	1 2 3	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com, jeff.allen@gmail.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 8 months ago (2014-08-29 07:22:14 UTC) #1

nigeltao

*** Submitted as https://code.google.com/p/go/source/detail?r=481bf3c07059 *** image/png: make the CompressionLevel constants negative, reserving positive numbers to ...

9 years, 8 months ago (2014-09-01 00:03:03 UTC) #4

gobot

9 years, 8 months ago (2014-09-01 00:19:16 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/9b2c90a5f34b1cd6a26309dc8db0c64027cd1d83

Expand All Messages | Collapse All Messages