Issue 13865043: Refactor content panel for re-use.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13865043: Refactor content panel for re-use.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by gary.poster

Modified:
10 years, 7 months ago

Reviewers:
mp+187355

Visibility:
Public.

Description

Refactor content panel for re-use. The content panel that has been used in the sidebar and the inspector wasn't very flexible and now that we want to use it for bundles I've cleaned it up so that we can re-use it without as much trouble. https://code.launchpad.net/~gary/juju-gui/huwshimi-bundle-ui-bits/+merge/187355 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Refactor content panel for re-use. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -184 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	app/subapps/browser/templates/sidebar.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/templates/service-inspector.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/templates/unitOverview.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/views/browser/charm-full.less	View	4 chunks	+53 lines, -96 lines	0 comments	Download
M	lib/views/browser/main.less	View	5 chunks	+2 lines, -9 lines	0 comments	Download
M	lib/views/browser/tabview.less	View	2 chunks	+38 lines, -22 lines	0 comments	Download
A	lib/views/content-panel.less	View	1 chunk	+63 lines, -0 lines	0 comments	Download
M	lib/views/juju-inspector.less	View	3 chunks	+14 lines, -50 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/test_browser_charm_details.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gary.poster

10 years, 7 months ago (2013-09-24 21:20:00 UTC) #2

*** Submitted:

Refactor content panel for re-use.

The content panel that has been used in the sidebar and the inspector wasn't
very flexible and now that we want to use it for bundles I've cleaned it up so
that we can re-use it without as much trouble.

R=
CC=
https://codereview.appspot.com/13865043

Expand All Messages | Collapse All Messages