Update ANGLE.sln

Update ANGLE.sln

BUG=
R=jmadill@chromium.org

Committed: https://code.google.com/p/angleproject/source/detail?r=1828a11

[Zhenyao Mo, 2013-09-24 20:37:12]

Shannon, can you take a look?

It seems like there are some differences caused by different Visual Studio, hope
that's still valid sln.

[Jamie Madill, 2013-09-24 20:52:47]

LGTM, given no compile errors.

https://codereview.appspot.com/13864045/diff/3001/src/ANGLE.sln
File src/ANGLE.sln (right):

https://codereview.appspot.com/13864045/diff/3001/src/ANGLE.sln#newcode3
src/ANGLE.sln:3: # Visual Studio 2010
We like to keep the solution files as Express, so that public contributors don't
need to buy the full editions. You could probably manually edit this line, or to
be safe, install VS 2010 Express and modify and save the solution with the free
version.

https://codereview.appspot.com/13864045/diff/3001/src/libGLESv2/libGLESv2.vcx...
File src/libGLESv2/libGLESv2.vcxproj (left):

https://codereview.appspot.com/13864045/diff/3001/src/libGLESv2/libGLESv2.vcx...
src/libGLESv2/libGLESv2.vcxproj:2: <Project DefaultTargets="Build"
ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
libGLESv2.vcxproj looks like it had a line-endings change. We have plans to fix
line-ending changes soon, but can you check if that's what's causing the large
diff?

[Shannon Woods, 2013-09-24 21:09:06]

https://codereview.appspot.com/13864045/diff/3001/src/ANGLE.sln
File src/ANGLE.sln (right):

https://codereview.appspot.com/13864045/diff/3001/src/ANGLE.sln#newcode3
src/ANGLE.sln:3: # Visual Studio 2010
On 2013/09/24 20:52:48, Jamie Madill wrote:
> We like to keep the solution files as Express, so that public contributors
don't
> need to buy the full editions. You could probably manually edit this line, or
to
> be safe, install VS 2010 Express and modify and save the solution with the
free
> version.

We'd definitely like to keep the projects loadable with Express. If this change
prevents Express versions from opening the project, it needs to be fixed before
commit. (I'm having trouble verifying myself locally.)

[Zhenyao Mo, 2013-09-24 23:16:11]

I manually edited the ANGLE.sln and libGLESv2.vcxproj files.

It seems to work fine on my side.  Can Jamie verify on your side?

[Jamie Madill, 2013-09-25 15:36:12]

On 2013/09/24 23:16:11, Zhenyao Mo wrote:
> I manually edited the ANGLE.sln and libGLESv2.vcxproj files.
> 
> It seems to work fine on my side.  Can Jamie verify on your side?

Hey Mo,

I applied the patch and there seems to be some slight oddity now with the
solution, it no longer has a default version visible in explorer on my machine.
Would it be possible to fix that? Usually we only edit the solution file with
VS2010 Express.

[Zhenyao Mo, 2013-09-25 16:49:40]

On 2013/09/25 15:36:12, Jamie Madill wrote:
> On 2013/09/24 23:16:11, Zhenyao Mo wrote:
> > I manually edited the ANGLE.sln and libGLESv2.vcxproj files.
> > 
> > It seems to work fine on my side.  Can Jamie verify on your side?
> 
> Hey Mo,
> 
> I applied the patch and there seems to be some slight oddity now with the
> solution, it no longer has a default version visible in explorer on my
machine.
> Would it be possible to fix that? Usually we only edit the solution file with
> VS2010 Express.

I did use 2010 express to edit the sln, but other than the first line that
indicate which VS you use in the sln file, otherwise the CL is the same as what
I got from 2010 professional (patch set 2).

However, I see a bunch of unnecessary changes in the diff (see delta between set
2 and set 3) that is not on other projects but the projects I touched. So I
removed them.

I don't see how these can make the version number disappear, because my manual
editing didn't touch any global settings. (Honestly I don't know which default
version you were talking about).

[Jamie Madill, 2013-09-25 17:23:55]

On 2013/09/25 16:49:40, Zhenyao Mo wrote:
> On 2013/09/25 15:36:12, Jamie Madill wrote:

> I don't see how these can make the version number disappear, because my manual
> editing didn't touch any global settings. (Honestly I don't know which default
> version you were talking about).

Seems to be a line ending problem, VS expects CRLF line endings in the project
and solution files.

[Zhenyao Mo, 2013-09-25 20:00:09]

Jamie,

I think I fixed the line endings issue.  Please take another try.

[Jamie Madill, 2013-09-25 20:12:26]

On 2013/09/25 20:00:09, Zhenyao Mo wrote:
> Jamie,
> 
> I think I fixed the line endings issue.  Please take another try.

LGTM, I think the line endings problem might just have been from downloading the
patch and using git apply? Not sure.

[Zhenyao Mo, 2013-09-25 20:14:52]

Committed patchset #4 manually as r1828a11 (presubmit successful).

[Zhenyao Mo, 2013-09-25 20:15:27]

On 2013/09/25 20:12:26, Jamie Madill wrote:
> On 2013/09/25 20:00:09, Zhenyao Mo wrote:
> > Jamie,
> > 
> > I think I fixed the line endings issue.  Please take another try.
> 
> LGTM, I think the line endings problem might just have been from downloading
the
> patch and using git apply? Not sure.

I must be me using wordpad to manually edit the files.