Generisize charm tokens more to just "tokens".

Generisize charm tokens more to just "tokens".

This is (hopefully) the last stop before rudimentary bundle tokens are
possible.

https://code.launchpad.net/~benji/juju-gui/genericize-token-code/+merge/187299

(do not edit description out of merge proposal)

[benji, 2013-09-24 17:25:31]

Please take a look.

[benji, 2013-09-24 19:13:20]

Please take a look.

[bac, 2013-09-24 19:49:49]

LGTM with some small changes.  I guess we are definitely going with 'token'
rather than 'deployable' or something less dumb.  I can live with it.

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js
File app/widgets/token.js (right):

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcode24
app/widgets/token.js:24: * information.
This sentence was not written by a native English speaker.  Please try again.

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcode54
app/widgets/token.js:54: // XXX This doesn't actually work yet, but soon.
Please sign and date your XXX.

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcode84
app/widgets/token.js:84: * @param {String} tokenData The JSON encoded charm
attributes.
s/charm/token

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcod...
app/widgets/token.js:119: * @param {String} tokenData The JSON encoded charm
attributes.
ditto

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcod...
app/widgets/token.js:140: // Adjust the id to meet Charm model expectations.
whack 'charm'?

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcod...
app/widgets/token.js:270: @attribute kind
In charmworld didn't we call this 'type'?  Might be nice to be consistent.

[benji, 2013-09-24 19:57:45]

Thanks for the review.  I've addressed all of your comments.

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js
File app/widgets/token.js (right):

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcode24
app/widgets/token.js:24: * information.
On 2013/09/24 19:49:49, bac wrote:
> This sentence was not written by a native English speaker.  Please try again.

Done.

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcode54
app/widgets/token.js:54: // XXX This doesn't actually work yet, but soon.
On 2013/09/24 19:49:49, bac wrote:
> Please sign and date your XXX.

Done.

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcode84
app/widgets/token.js:84: * @param {String} tokenData The JSON encoded charm
attributes.
On 2013/09/24 19:49:49, bac wrote:
> s/charm/token

Done.

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcod...
app/widgets/token.js:119: * @param {String} tokenData The JSON encoded charm
attributes.
On 2013/09/24 19:49:49, bac wrote:
> ditto

Done.

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcod...
app/widgets/token.js:140: // Adjust the id to meet Charm model expectations.
On 2013/09/24 19:49:49, bac wrote:
> whack 'charm'?

Done.

https://codereview.appspot.com/13860044/diff/9001/app/widgets/token.js#newcod...
app/widgets/token.js:270: @attribute kind
On 2013/09/24 19:49:49, bac wrote:
> In charmworld didn't we call this 'type'?  Might be nice to be consistent.

Good call.  Done.

[benji, 2013-09-24 20:08:21]

*** Submitted:

Generisize charm tokens more to just "tokens".

This is (hopefully) the last stop before rudimentary bundle tokens are
possible.

R=bac
CC=
https://codereview.appspot.com/13860044