Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2018)

Issue 13858043: code review 13858043: cmd/cgo: retain Go pointer passed to C call for duratio... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by rsc
Modified:
6 years ago
Reviewers:
iant
CC:
golang-dev, bradfitz, iant
Visibility:
Public.

Description

cmd/cgo: retain Go pointer passed to C call for duration of call Fixes issue 6397.

Patch Set 1 #

Patch Set 2 : diff -r 1607e9e9e6de https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1607e9e9e6de https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 1607e9e9e6de https://code.google.com/p/go/ #

Patch Set 5 : diff -r 1607e9e9e6de https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M src/cmd/cc/pgen.c View 1 3 chunks +14 lines, -5 lines 0 comments Download
M src/cmd/cgo/out.go View 1 2 3 4 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
6 years ago (2013-09-24 14:02:13 UTC) #1
bradfitz
https://codereview.appspot.com/13858043/diff/5001/src/cmd/cgo/out.go File src/cmd/cgo/out.go (right): https://codereview.appspot.com/13858043/diff/5001/src/cmd/cgo/out.go#newcode420 src/cmd/cgo/out.go:420: if argSize/p.PtrSize > 0 { if n := argSize/p.PtrSize; ...
6 years ago (2013-09-24 14:17:45 UTC) #2
iant
LGTM
6 years ago (2013-09-24 15:20:48 UTC) #3
rsc
6 years ago (2013-09-24 19:52:54 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=b2ddbf1de068 ***

cmd/cgo: retain Go pointer passed to C call for duration of call

Fixes issue 6397.

R=golang-dev, bradfitz, iant
CC=golang-dev
https://codereview.appspot.com/13858043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b