Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(465)

Issue 138470043: code review 138470043: ogle/program: add pc/sp/file/line info to the program.F... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by nigeltao
Modified:
7 years, 2 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/program: add pc/sp/file/line info to the program.Frame structure.

Patch Set 1 #

Patch Set 2 : diff -r 55b3bcd8bbc825e628d82a63e60941889e5c8d13 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 55b3bcd8bbc825e628d82a63e60941889e5c8d13 https://code.google.com/p/ogle #

Total comments: 1

Patch Set 4 : diff -r 55b3bcd8bbc825e628d82a63e60941889e5c8d13 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M program/program.go View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M program/server/server.go View 1 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 5
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 2 months ago (2014-09-16 06:10:07 UTC) #1
r
LGTM but please put little comments on those fields. PC and SP are real registers ...
7 years, 2 months ago (2014-09-16 19:47:54 UTC) #2
nigeltao
On 2014/09/16 19:47:54, r wrote: > LGTM but please put little comments on those fields. ...
7 years, 2 months ago (2014-09-16 23:31:59 UTC) #3
r
s/is the/& hardware/ and i'll be happy On Tue, Sep 16, 2014 at 4:31 PM, ...
7 years, 2 months ago (2014-09-17 00:28:29 UTC) #4
nigeltao
7 years, 2 months ago (2014-09-17 00:50:12 UTC) #5
*** Submitted as https://code.google.com/p/ogle/source/detail?r=ad5c1d60b3d2 ***

ogle/program: add pc/sp/file/line info to the program.Frame structure.

LGTM=r
R=r
https://codereview.appspot.com/138470043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b