Issue 13845044: code review 13845044: misc/pprof: support block profile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13845044: code review 13845044: misc/pprof: support block profile (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

misc/pprof: support block profile Fixes issue 6347.

Patch Set 1 #

Patch Set 2 : diff -r 44e7a81a3736 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 44e7a81a3736 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 44e7a81a3736 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r e98b4542af61 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	misc/pprof	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 7 months ago (2013-09-23 20:31:29 UTC) #1

rsc

have you tested this? i wondered if it needs to be handled in any other ...

11 years, 7 months ago (2013-09-23 20:33:55 UTC) #2

dvyukov

11 years, 7 months ago (2013-09-23 21:16:09 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=ec7b58d6a977 ***

misc/pprof: support block profile
Fixes issue 6347.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13845044

Expand All Messages | Collapse All Messages