Data-bind unit details view

Data-bind unit details view

Our unit detail view was not data-bound: it would render and never update.  This branch fixes that, except for the relation information, which is not really available at the moment (in terms of errors) so I decided that could live to fight another day.

https://code.launchpad.net/~gary/juju-gui/bug1228166/+merge/187311

(do not edit description out of merge proposal)

[gary.poster, 2013-09-24 18:17:30]

Please take a look.

[jeff.pihach, 2013-09-24 18:37:48]

Code LGTM with trivial and will QA and report back.

https://codereview.appspot.com/13841044/diff/1/app/views/viewlets/unit-detail...
File app/views/viewlets/unit-details.js (right):

https://codereview.appspot.com/13841044/diff/1/app/views/viewlets/unit-detail...
app/views/viewlets/unit-details.js:40: if (value) {
if everything requires a value I would do:

if (!value) { return; } 

just to avoid the indentation throughout the whole function (personal
preference)

https://codereview.appspot.com/13841044/diff/1/app/views/viewlets/unit-detail...
app/views/viewlets/unit-details.js:89: 'get': function(model) {
What is this for? Where is it used?

https://codereview.appspot.com/13841044/diff/1/test/test_unit_detail_viewlet.js
File test/test_unit_detail_viewlet.js (right):

https://codereview.appspot.com/13841044/diff/1/test/test_unit_detail_viewlet....
test/test_unit_detail_viewlet.js:67: assert.strictEqual(node.getContent(), '');
getContent() is deprecated in favour of getHTML()

[jeff.pihach, 2013-09-24 18:46:06]

QA NOT OK - trivial

ip is not a link unless ports are visible
the resulting links afterwards do not match the ports you click on, and the ip
has no port added.

[jeff.pihach, 2013-09-24 20:22:56]

QA OK after discussion Thanks

[gary.poster, 2013-09-24 20:31:50]

On 2013/09/24 18:37:48, jeff.pihach wrote:
> Code LGTM with trivial and will QA and report back.

Thank you very much for review and qa!

> 
>
https://codereview.appspot.com/13841044/diff/1/app/views/viewlets/unit-detail...
> File app/views/viewlets/unit-details.js (right):
> 
>
https://codereview.appspot.com/13841044/diff/1/app/views/viewlets/unit-detail...
> app/views/viewlets/unit-details.js:40: if (value) {
> if everything requires a value I would do:
> 
> if (!value) { return; } 
> 
> just to avoid the indentation throughout the whole function (personal
> preference)

Yeah, I dunno.  I changed it to match your preference this time. :-)

> 
>
https://codereview.appspot.com/13841044/diff/1/app/views/viewlets/unit-detail...
> app/views/viewlets/unit-details.js:89: 'get': function(model) {
> What is this for? Where is it used?

We discussed, and with Ben decided to move the functionality into databinding
and remove the extension feature I was using.

> 
>
https://codereview.appspot.com/13841044/diff/1/test/test_unit_detail_viewlet.js
> File test/test_unit_detail_viewlet.js (right):
> 
>
https://codereview.appspot.com/13841044/diff/1/test/test_unit_detail_viewlet....
> test/test_unit_detail_viewlet.js:67: assert.strictEqual(node.getContent(),
'');
> getContent() is deprecated in favour of getHTML()

Ah!  Thanks, changed.

[gary.poster, 2013-09-24 20:35:23]

*** Submitted:

Data-bind unit details view

Our unit detail view was not data-bound: it would render and never update.  This
branch fixes that, except for the relation information, which is not really
available at the moment (in terms of errors) so I decided that could live to
fight another day.

R=jeff.pihach
CC=
https://codereview.appspot.com/13841044