Issue 13840047: code review 13840047: go.tools/go/types: test case for issue 6413

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13840047: code review 13840047: go.tools/go/types: test case for issue 6413 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by gri

Modified:
12 years, 1 month ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go.tools/go/types: test case for issue 6413 Fixes issue 6413.

Patch Set 2 : diff -r 383f789c3426 https://code.google.com/p/go.tools #

Total comments: 4

Patch Set 3 : diff -r 383f789c3426 https://code.google.com/p/go.tools #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -5 lines)			Patch
	M	go/types/issues_test.go	View	1 2	3 chunks	+40 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello adonovan (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 1 month ago (2013-09-24 19:45:58 UTC) #1

adonovan

LGTM https://codereview.appspot.com/13840047/diff/4001/go/types/issues_test.go File go/types/issues_test.go (right): https://codereview.appspot.com/13840047/diff/4001/go/types/issues_test.go#newcode21 go/types/issues_test.go:21: return You don't need return after fatal, since ...

12 years, 1 month ago (2013-09-24 19:47:28 UTC) #2

gri

Fixed. Were leftover dreggs. https://codereview.appspot.com/13840047/diff/4001/go/types/issues_test.go File go/types/issues_test.go (right): https://codereview.appspot.com/13840047/diff/4001/go/types/issues_test.go#newcode21 go/types/issues_test.go:21: return On 2013/09/24 19:47:28, adonovan ...

12 years, 1 month ago (2013-09-24 19:48:17 UTC) #3

gri

12 years, 1 month ago (2013-09-24 19:51:49 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=25af63848c8d&repo=tools ***

go.tools/go/types: test case for issue 6413

Fixes issue 6413.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/13840047

Expand All Messages | Collapse All Messages