Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 13839047: code review 13839047: go.crypto/ssh/terminal: Allow ^A and ^E as synonyms for...

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 12 months ago by sfrithjof
Modified:
5 years, 11 months ago
Reviewers:
CC:
golang-dev, agl1
Visibility:
Public.

Description

go.crypto/ssh/terminal: Allow ^A and ^E as synonyms for Home and End. I understand that ssh/terminal can't implement everybodys favorite keyboard shortcuts, but I think these are very widespread. They exist not only in Emacs or Readline, but also in Acme and Sam. Also they almost come for free.

Patch Set 1 #

Patch Set 2 : diff -r 3a49c11added https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 3a49c11added https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r ca17ccb492a0 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ssh/terminal/terminal.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ssh/terminal/terminal_test.go View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
sfrithjof
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
5 years, 12 months ago (2013-09-24 19:43:30 UTC) #1
sfrithjof
Hello golang-dev@googlegroups.com (cc: agl@golang.org, golang-dev@googlegroups.com), Please take another look.
5 years, 11 months ago (2013-09-27 08:31:13 UTC) #2
agl1
5 years, 11 months ago (2013-09-30 20:06:12 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=2cd6b3b93cdb&repo=crypto ***

go.crypto/ssh/terminal: Allow ^A and ^E as synonyms for Home and End.

I understand that ssh/terminal can't implement everybodys
favorite keyboard shortcuts, but I think these are very
widespread. They exist not only in Emacs or Readline, but also
in Acme and Sam. Also they almost come for free.

R=golang-dev
CC=agl, golang-dev
https://codereview.appspot.com/13839047

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b