Issue 13839046: environs: implement Destroy function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13839046: environs: implement Destroy function

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
mue, mp+187196

Visibility:
Public.

Description

environs: implement Destroy function This isn't used yet, but will be, when configstore info gets created with each environment. https://code.launchpad.net/~rogpeppe/juju-core/418-environs-destroy/+merge/187196 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: implement Destroy function #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/open.go	View	2 chunks	+21 lines, -0 lines	0 comments	Download
M	environs/open_test.go	View	2 chunks	+30 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mue

10 years, 7 months ago (2013-09-24 13:34:25 UTC) #2

LGTM, only one comment regarding a topic outside of this CL.

https://codereview.appspot.com/13839046/diff/3001/environs/open_test.go
File environs/open_test.go (right):

https://codereview.appspot.com/13839046/diff/3001/environs/open_test.go#newco...
environs/open_test.go:143: store := configstore.NewMem()
Has nothing to do with this CL but here is one point I simply would like to
avoid abbreviations. NewMemory() would read better.

Expand All Messages | Collapse All Messages