Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(181)

Issue 138330045: code review 138330045: runtime: fix cgo to handle the case where the G stack i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by khr
Modified:
10 years, 7 months ago
Reviewers:
gobot, rsc, khr1, iant
CC:
rsc, iant, golang-codereviews
Visibility:
Public.

Description

runtime: fix cgo to handle the case where the G stack is copied. Tests will come in a separate CL after the funcdata stuff is resolved. Update issue 8696

Patch Set 1 #

Patch Set 2 : diff -r d57c70faea519ccec05d9913316d628f46ad0c70 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r d57c70faea519ccec05d9913316d628f46ad0c70 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 2d6d44ceb80e0326adafdef07a2988f9db10144b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M src/runtime/asm_386.s View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/runtime/asm_amd64.s View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/runtime/asm_arm.s View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8
khr
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
10 years, 7 months ago (2014-09-11 23:42:23 UTC) #1
iant
LGTM
10 years, 7 months ago (2014-09-12 00:45:03 UTC) #2
rsc
LGTM
10 years, 7 months ago (2014-09-12 01:17:01 UTC) #3
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=3cc56d312b1d *** runtime: fix cgo to handle the case where the G ...
10 years, 7 months ago (2014-09-12 03:36:27 UTC) #4
gobot
This CL appears to have broken the linux-amd64 builder. See http://build.golang.org/log/93ed6bfb1bf023b3adc2fd6063af6cb8b6d9a916
10 years, 7 months ago (2014-09-12 03:40:03 UTC) #5
khr
*** Abandoned ***
10 years, 7 months ago (2014-09-24 23:00:02 UTC) #6
rsc
fwiw you can use 'hg change -D' to avoid sending mail in this case
10 years, 7 months ago (2014-09-24 23:05:58 UTC) #7
khr1
10 years, 7 months ago (2014-09-24 23:08:35 UTC) #8
Yes, I always forget which case is which...


On Wed, Sep 24, 2014 at 4:05 PM, Russ Cox <rsc@golang.org> wrote:

> fwiw you can use 'hg change -D' to avoid sending mail in this case
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b