Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 13832044: Repair remove unit button

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by bcsaller
Modified:
10 years, 7 months ago
Reviewers:
jeff.pihach, mp+187128
Visibility:
Public.

Description

Repair remove unit button Python and Go have differnt remove unit signatures, we called it in a loop with single names but the go env still expected an array, not a string. This will conditionally trigger the behavior based on env type. https://code.launchpad.net/~bcsaller/juju-gui/inspector-removeunit/+merge/187128 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Repair remove unit button #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/inspector.js View 1 chunk +7 lines, -3 lines 0 comments Download
M test/test_inspector_overview.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
bcsaller
Please take a look.
10 years, 7 months ago (2013-09-24 00:44:56 UTC) #1
jeff.pihach
LGTM Thanks for this fix (chunk missmatch so no notes)
10 years, 7 months ago (2013-09-24 14:16:28 UTC) #2
benjamin.saller
Thanks for the review anyway. I think maybe a better plan is to put the ...
10 years, 7 months ago (2013-09-24 15:34:01 UTC) #3
bcsaller
10 years, 7 months ago (2013-09-24 15:39:18 UTC) #4
*** Submitted:

Repair remove unit button

Python and Go have differnt remove unit signatures, we 
called it in a loop with single names but the go env still
expected an array, not a string. This will conditionally
trigger the behavior based on env type.

R=jeff.pihach
CC=
https://codereview.appspot.com/13832044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b