Issue 13830043: code review 13830043: doc/go1.2: document that godoc and vet will always be i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13830043: code review 13830043: doc/go1.2: document that godoc and vet will always be i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by minux1

Modified:
11 years, 11 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

doc/go1.2: document that godoc and vet will always be installed to their old locations (not $GOPATH/bin).

Patch Set 2 : diff -r ff20684a4492 https://code.google.com/p/go #

Patch Set 3 : diff -r ff20684a4492 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r ff20684a4492 https://code.google.com/p/go #

Patch Set 5 : diff -r 00a53cf2d774 https://code.google.com/p/go #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	doc/go1.2.html	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 11 months ago (2013-09-23 04:54:28 UTC) #1

LGTM https://codereview.appspot.com/13830043/diff/6001/doc/go1.2.html File doc/go1.2.html (right): https://codereview.appspot.com/13830043/diff/6001/doc/go1.2.html#newcode178 doc/go1.2.html:178: (They will be installed to their usual locations, ...

11 years, 11 months ago (2013-09-23 05:06:25 UTC) #2

minux1

11 years, 11 months ago (2013-09-23 05:23:47 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d1b8c87a7b3d ***

doc/go1.2: document that godoc and vet will always be installed to their old
locations (not $GOPATH/bin).

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/13830043

https://codereview.appspot.com/13830043/diff/6001/doc/go1.2.html
File doc/go1.2.html (right):

https://codereview.appspot.com/13830043/diff/6001/doc/go1.2.html#newcode178
doc/go1.2.html:178: (They will be installed to their usual locations, not
<code>$GOPATH/bin</code>.)
On 2013/09/23 05:06:25, r wrote:
> how about
> 
> (The binaries will continue to be installed in their ....
Done, and folded the line.

Expand All Messages | Collapse All Messages