Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(925)

Issue 13827043: state/apiserver: add test for ignored rpc methods

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rog
Modified:
10 years, 7 months ago
Reviewers:
jameinel, mp+186945
Visibility:
Public.

Description

state/apiserver: add test for ignored rpc methods With the rpcreflect package in place, we can make a test that makes sure that RPC methods are not ignored without good cause. We could also potentially add a test that the set of exported RPC methods is exactly what is expected, which might actually be useful to make sure that we are not accidentally exporting unintended functionality. https://code.launchpad.net/~rogpeppe/juju-core/414-apiserver-test-discarded/+merge/186945 Requires: https://code.launchpad.net/~rogpeppe/juju-core/411-rpc-introspection/+merge/186909 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/apiserver: add test for ignored rpc methods #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A state/apiserver/export_test.go View 1 chunk +8 lines, -0 lines 0 comments Download
A state/apiserver/root_test.go View 1 chunk +43 lines, -0 lines 1 comment Download

Messages

Total messages: 2
rog
Please take a look.
10 years, 7 months ago (2013-09-22 19:56:31 UTC) #1
jameinel
10 years, 7 months ago (2013-09-23 09:29:10 UTC) #2
LGTM provided the earlier patch lands.

https://codereview.appspot.com/13827043/diff/3001/state/apiserver/root_test.go
File state/apiserver/root_test.go (right):

https://codereview.appspot.com/13827043/diff/3001/state/apiserver/root_test.g...
state/apiserver/root_test.go:42: }
I'm ok with a blacklist, but we might just want a whitelist test. (both?) and
then when you add something you update the lists.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b