Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4684)

Issue 13824045: New juju-deployer darwin version.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by frankban
Modified:
10 years, 7 months ago
Reviewers:
bac, mp+187015, gary.poster
Visibility:
Public.

Description

New juju-deployer darwin version. Switched to the new juju-deployer version, which includes support for deployments started by the GUI server. This allows us to remove the blocking/deployer-specific code from the GUI server. Also updated the relevant parts of the documentation. Tests: run `make unittest` from the root of this branch. https://code.launchpad.net/~frankban/charms/precise/juju-gui/new-darwin/+merge/187015 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : New juju-deployer darwin version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -466 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
D deps/juju-deployer-0.2.2.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/juju-deployer-0.2.3.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
M hooks/utils.py View 1 chunk +1 line, -1 line 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/bundles/__init__.py View 1 2 chunks +14 lines, -13 lines 0 comments Download
M server/guiserver/bundles/base.py View 3 chunks +15 lines, -2 lines 0 comments Download
D server/guiserver/bundles/blocking.py View 1 chunk +0 lines, -143 lines 0 comments Download
M server/guiserver/tests/bundles/test_base.py View 1 chunk +2 lines, -1 line 0 comments Download
D server/guiserver/tests/bundles/test_blocking.py View 1 chunk +0 lines, -189 lines 0 comments Download
M server/guiserver/tests/helpers.py View 3 chunks +3 lines, -49 lines 0 comments Download
M server/guiserver/tests/test_utils.py View 2 chunks +0 lines, -51 lines 0 comments Download
M server/guiserver/utils.py View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 7 months ago (2013-09-23 13:09:12 UTC) #1
gary.poster
LGTM. No qa, guessing bac is doing it. Thank you for getting this into the ...
10 years, 7 months ago (2013-09-23 13:37:05 UTC) #2
bac
LGTM with minor typo. Ran the tests but after talking to Francesco did not do ...
10 years, 7 months ago (2013-09-23 14:23:17 UTC) #3
frankban
*** Submitted: New juju-deployer darwin version. Switched to the new juju-deployer version, which includes support ...
10 years, 7 months ago (2013-09-23 14:52:33 UTC) #4
frankban
10 years, 7 months ago (2013-09-23 15:35:17 UTC) #5
Thank you both for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b