Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(168)

Issue 13821044: GCC compilation fixes.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by jacek
Modified:
10 years, 6 months ago
Visibility:
Public.

Description

GCC compilation fixes. Those are a few trivial fixes: - Fixed includes on case sensitive OSes (also renamed constants.h to Constatns.h, which was used in more places) - Use __GXX_RTTI instead of assuming that all non-MSVC compilers support rtti (fixes compilation in Mozilla tree, where -fno-rtti is used) - Specify hashing of DXGI_FORMAT because this enum has no hash<> specialization

Patch Set 1 #

Patch Set 2 : Fixed rtti detection on GCC versions not supporting __GCC_RTTI #

Patch Set 3 : Added a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/common/debug.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
A + src/libGLESv2/Constants.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/libGLESv2/Framebuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libGLESv2/precompiled.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/libGLESv2/renderer/Renderer11.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libGLESv2/renderer/Renderer11.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
jacek
10 years, 6 months ago (2013-09-23 10:30:36 UTC) #1
Alok Priyadarshi
+shannon should review this patch.
10 years, 6 months ago (2013-09-23 16:40:01 UTC) #2
Shannon Woods
On 2013/09/23 16:40:01, Alok Priyadarshi wrote: > +shannon should review this patch. __GXX_RTTI is only ...
10 years, 6 months ago (2013-09-23 17:29:59 UTC) #3
jacek
On 2013/09/23 17:29:59, shannonwoods wrote: > On 2013/09/23 16:40:01, Alok Priyadarshi wrote: > > +shannon ...
10 years, 6 months ago (2013-09-24 09:25:20 UTC) #4
Shannon Woods
On 2013/09/24 09:25:20, jacek wrote: > On 2013/09/23 17:29:59, shannonwoods wrote: > > On 2013/09/23 ...
10 years, 6 months ago (2013-09-24 16:06:37 UTC) #5
jacek
On 2013/09/24 16:06:37, Shannon Woods wrote: > On 2013/09/24 09:25:20, jacek wrote: > > On ...
10 years, 6 months ago (2013-09-25 09:54:11 UTC) #6
Shannon Woods
On 2013/09/25 09:54:11, jacek wrote: > On 2013/09/24 16:06:37, Shannon Woods wrote: > > On ...
10 years, 6 months ago (2013-09-25 16:11:12 UTC) #7
jacek
On 2013/09/25 16:11:12, Shannon Woods wrote: > On 2013/09/25 09:54:11, jacek wrote: > > On ...
10 years, 6 months ago (2013-09-25 16:17:40 UTC) #8
Shannon Woods
10 years, 6 months ago (2013-09-26 21:11:58 UTC) #9
On 2013/09/25 16:17:40, jacek wrote:
> On 2013/09/25 16:11:12, Shannon Woods wrote:
> > On 2013/09/25 09:54:11, jacek wrote:
> > > On 2013/09/24 16:06:37, Shannon Woods wrote:
> > > > On 2013/09/24 09:25:20, jacek wrote:
> > > > > On 2013/09/23 17:29:59, shannonwoods wrote:
> > > > > > On 2013/09/23 16:40:01, Alok Priyadarshi wrote:
> > > > > > > +shannon should review this patch.
> > > > > > 
> > > > > > __GXX_RTTI is only supported by gcc 4.3.2+, and I'm not sure of its
> > > suppport
> > > > > > outside of gcc. Could we check its presence only on the appropriate
> > > versions
> > > > > of
> > > > > > gcc?
> > > > > 
> > > > > Thanks for review. The new versions checks both for presence of GCC
and
> > its
> > > > > version.
> > > > 
> > > > Could probably use a comment explaining what it's checking; aside from
> that,
> > > > LGTM
> > > 
> > > Thanks. The new version includes a comment.
> > 
> > Great, LGTM. Do you need someone to land this for you?
> 
> Yes, please. I can't land it myself.

Landed at re6dcc9815a8a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b