Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(404)

Issue 13816043: code review 13816043: doc/go1.2.html: pre-emption; cgo and C++ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by r
Modified:
11 years, 6 months ago
Reviewers:
dvyukov
CC:
golang-dev, dvyukov
Visibility:
Public.

Description

doc/go1.2.html: pre-emption; cgo and C++ These were bullet points that I had neglected to flesh out.

Patch Set 1 #

Total comments: 4

Patch Set 2 : diff -r c3d59e71d6b2 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 62e67a664a03 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M doc/go1.2.html View 1 1 chunk +18 lines, -8 lines 0 comments Download

Messages

Total messages: 6
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2013-09-21 06:28:54 UTC) #1
dvyukov
https://codereview.appspot.com/13816043/diff/1/doc/go1.2.html File doc/go1.2.html (right): https://codereview.appspot.com/13816043/diff/1/doc/go1.2.html#newcode134 doc/go1.2.html:134: In Go1.2, this is partially addressed: The scheduler is ...
11 years, 6 months ago (2013-09-21 06:36:05 UTC) #2
r
https://codereview.appspot.com/13816043/diff/1/doc/go1.2.html File doc/go1.2.html (right): https://codereview.appspot.com/13816043/diff/1/doc/go1.2.html#newcode134 doc/go1.2.html:134: In Go1.2, this is partially addressed: The scheduler is ...
11 years, 6 months ago (2013-09-21 07:22:26 UTC) #3
r
Hello golang-dev@googlegroups.com, dvyukov@google.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 6 months ago (2013-09-21 07:23:02 UTC) #4
dvyukov
LGTM
11 years, 6 months ago (2013-09-21 07:26:23 UTC) #5
r
11 years, 6 months ago (2013-09-21 07:53:58 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=125bf33c1905 ***

doc/go1.2.html: pre-emption; cgo and C++

These were bullet points that I had neglected to flesh out.

R=golang-dev, dvyukov
CC=golang-dev
https://codereview.appspot.com/13816043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b