state, testing: fix for mongo >2.2

state, testing: fix for mongo >2.2

As reported by sinzui on #juju-dev, the tests
fail when run against mongod 2.4.5.

This should fix that. I've left the two isUnauthorized
functions duplicated for dependency-hygiene reasons.

Plus a drive-by fix to a sporadic test failure in environs-cloudinit - the
regexp didn't admit all base64 characters.

https://code.launchpad.net/~rogpeppe/juju-core/409-fix-for-mongo.2.4/+merge/186839

(do not edit description out of merge proposal)

[rog, 2013-09-20 17:11:08]

Please take a look.

[gz, 2013-09-20 17:26:23]

LGTM, even with the duplicated function which I'm not wild about it's an
improvement on the current.

https://codereview.appspot.com/13808043/diff/6001/environs/cloudinit/cloudini...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/13808043/diff/6001/environs/cloudinit/cloudini...
environs/cloudinit/cloudinit_test.go:278: re := regexp.MustCompile(`--env-config
'([\w,=+/]+)'`)
So, are we using standard base64 or urlsafe base64? Feels like we should know,
rather than just matching both.

https://codereview.appspot.com/13808043/diff/6001/state/open.go
File state/open.go (right):

https://codereview.appspot.com/13808043/diff/6001/state/open.go#newcode200
state/open.go:200: if err, ok := err.(*mgo.QueryError); ok {
I take it there's no mongo doc page we can link to in a comment that specifies
what these are?

https://codereview.appspot.com/13808043/diff/6001/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/13808043/diff/6001/testing/mgo.go#newcode268
testing/mgo.go:268: // isUnauthorized is a copy of the same function in
state/open.go.
Well, at least it's commented that it's a copy...

[gz, 2013-09-20 17:33:35]

https://codereview.appspot.com/13808043/diff/6001/environs/cloudinit/cloudini...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/13808043/diff/6001/environs/cloudinit/cloudini...
environs/cloudinit/cloudinit_test.go:278: re := regexp.MustCompile(`--env-config
'([\w,=+/]+)'`)
On 2013/09/20 17:26:24, gz wrote:
> So, are we using standard base64 or urlsafe base64? Feels like we should know,
> rather than just matching both.

Misread, this adds the two extra standard characters, and '-_' which are used by
websafe are not present.

[rog, 2013-09-20 17:36:23]

Please take a look.

https://codereview.appspot.com/13808043/diff/6001/state/open.go
File state/open.go (right):

https://codereview.appspot.com/13808043/diff/6001/state/open.go#newcode200
state/open.go:200: if err, ok := err.(*mgo.QueryError); ok {
On 2013/09/20 17:26:24, gz wrote:
> I take it there's no mongo doc page we can link to in a comment that specifies
> what these are?

http://www.mongodb.org/about/contributors/error-codes/
is pretty useless.

[rog, 2013-09-20 17:38:38]

https://codereview.appspot.com/13808043/diff/6001/environs/cloudinit/cloudini...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/13808043/diff/6001/environs/cloudinit/cloudini...
environs/cloudinit/cloudinit_test.go:278: re := regexp.MustCompile(`--env-config
'([\w,=+/]+)'`)
On 2013/09/20 17:26:24, gz wrote:
> So, are we using standard base64 or urlsafe base64? Feels like we should know,
> rather than just matching both.

Standard, but on reflection there's no particular reason to duplicate the base64
alphabet here. I've simplified the regexp - the test is actually stronger that
way in fact because the base64 decoder will barf if it finds a non-standard
character.