Issue 13806043: environs/configstore: use JUJU_HOME for root

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13806043: environs/configstore: use JUJU_HOME for root

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
mp+186725, axw1

Visibility:
Public.

Description

environs/configstore: use JUJU_HOME for root This means the environments directory can be automatically created on demand, and makes it possible for diskStorage to return information from environments.yaml in a future iteration of the ConfigStorage interface. https://code.launchpad.net/~rogpeppe/juju-core/405-configstore-fix-dir/+merge/186725 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/configstore: use JUJU_HOME for root #

Patch Set 3 : environs/configstore: use JUJU_HOME for root #

Patch Set 4 : environs/configstore: use JUJU_HOME for root #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -17 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/configstore/disk.go	View		1 chunk	+13 lines, -3 lines	0 comments	Download
M	environs/configstore/disk_test.go	View		7 chunks	+25 lines, -13 lines	0 comments	Download
M	juju/api.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

axw1

On 2013/09/20 08:55:35, rog wrote: > Please take a look. LGTM. Maybe an explicit test ...

10 years, 7 months ago (2013-09-20 09:03:42 UTC) #2

axw1

On 2013/09/20 09:03:42, axw1 wrote: > On 2013/09/20 08:55:35, rog wrote: > > Please take ...

10 years, 7 months ago (2013-09-20 09:04:25 UTC) #3

Please take a look.

Expand All Messages | Collapse All Messages