Issue 138050043: code review 138050043: runtime: fix Plan 9 build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 138050043: code review 138050043: runtime: fix Plan 9 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by 0intro

Modified:
10 years, 6 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

runtime: fix Plan 9 build

Patch Set 1 #

Patch Set 2 : diff -r 0497f2442c7e4bc82b6a488aecd22f23933e7bda https://code.google.com/p/go #

Patch Set 3 : diff -r f299fefb123fb13f49025e418ba104146e622ae1 https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	src/pkg/runtime/os_plan9.c	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
	M	src/pkg/runtime/os_plan9.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

0intro

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2014-09-04 05:40:03 UTC) #1

0intro

*** Submitted as https://code.google.com/p/go/source/detail?r=22ab53e057c9 *** runtime: fix Plan 9 build LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/138050043

10 years, 6 months ago (2014-09-04 06:36:27 UTC) #3

gobot

10 years, 6 months ago (2014-09-04 07:24:08 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/f07372f979e7cee885023ffe936edebff1b4e990

Expand All Messages | Collapse All Messages