code review 138040043: go.tools/cmd/stringer: Fix build on 32bit OSs.

go.tools/cmd/stringer: Fix build on 32bit OSs.

[mattn, 2014-09-04 03:37:51]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[gri, 2014-09-04 03:43:04]

https://codereview.appspot.com/138040043/diff/40001/cmd/stringer/stringer.go
File cmd/stringer/stringer.go (right):

https://codereview.appspot.com/138040043/diff/40001/cmd/stringer/stringer.go#...
cmd/stringer/stringer.go:458: return 64
return 32

64 is extremely unlikely I think but leaving for r

[r, 2014-09-04 04:55:08]

LGTM after change to 32.

https://codereview.appspot.com/138040043/diff/40001/cmd/stringer/stringer.go
File cmd/stringer/stringer.go (right):

https://codereview.appspot.com/138040043/diff/40001/cmd/stringer/stringer.go#...
cmd/stringer/stringer.go:458: return 64
On 2014/09/04 03:43:04, gri wrote:
> return 32
> 
> 64 is extremely unlikely I think but leaving for r

I agree. 32 is fine. more than 2 billion constants? the compiler won't even
compile it, i'm sure.

[mattn, 2014-09-04 06:48:52]

Hello golang-codereviews@googlegroups.com, gri@golang.org, r@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[mattn, 2014-09-04 06:49:35]

https://codereview.appspot.com/138040043/diff/40001/cmd/stringer/stringer.go
File cmd/stringer/stringer.go (right):

https://codereview.appspot.com/138040043/diff/40001/cmd/stringer/stringer.go#...
cmd/stringer/stringer.go:458: return 64
On 2014/09/04 04:55:08, r wrote:
> On 2014/09/04 03:43:04, gri wrote:
> > return 32
> > 
> > 64 is extremely unlikely I think but leaving for r
> 
> I agree. 32 is fine. more than 2 billion constants? the compiler won't even
> compile it, i'm sure.
> 

Done.

[r, 2014-09-04 14:49:32]

LGTM

[r, 2014-09-04 17:51:42]

*** Submitted as
https://code.google.com/p/go/source/detail?r=4c2a8e992d65&repo=tools ***

go.tools/cmd/stringer: Fix build on 32bit OSs.

LGTM=r
R=golang-codereviews, gri, r
CC=golang-codereviews
https://codereview.appspot.com/138040043

Committer: Rob Pike <r@golang.org>