Issue 138000045: code review 138000045: runtime: fix int64 reconstruction in semasleep

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 138000045: code review 138000045: runtime: fix int64 reconstruction in semasleep (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rsc

Modified:
10 years, 8 months ago

Reviewers:
dave

CC:
dave_cheney.net, golang-codereviews

Visibility:
Public.

Description

runtime: fix int64 reconstruction in semasleep I had this right in one of my clients, but apparently not the one I submitted from. Fixes 386 builds.

Patch Set 1 #

Patch Set 2 : diff -r 5179e31ac3dab8e8d3f72fcb0ff1825f3adc016f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0497f2442c7e4bc82b6a488aecd22f23933e7bda https://code.google.com/p/go/ #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/os_darwin.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello dfc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 8 months ago (2014-09-04 05:38:46 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=2b284598386f *** runtime: fix int64 reconstruction in semasleep I had this right ...

10 years, 8 months ago (2014-09-04 05:38:54 UTC) #2

dave_cheney.net

10 years, 8 months ago (2014-09-04 05:45:14 UTC) #3

LGTM. Thanks.

On Thu, Sep 4, 2014 at 3:38 PM,  <rsc@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=2b284598386f ***
>
>
> runtime: fix int64 reconstruction in semasleep
>
> I had this right in one of my clients, but apparently not the one I
> submitted from.
>
> Fixes 386 builds.
>
> TBR=dfc
> CC=golang-codereviews
> https://codereview.appspot.com/138000045
>
>
> https://codereview.appspot.com/138000045/

Expand All Messages | Collapse All Messages