Issue 137920044: code review 137920044: runtime: handle empty environment variables on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 137920044: code review 137920044: runtime: handle empty environment variables on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by 0intro

Modified:
10 years, 6 months ago

Reviewers:
rsc, bradfitz

CC:
rsc, bradfitz, golang-codereviews

Visibility:
Public.

Description

runtime: handle empty environment variables on Plan 9

Patch Set 2 : diff -r bc9245d02338ac13d7b3ca552c6e0bbd87bba65d https://code.google.com/p/go #

Total comments: 1

Patch Set 3 : diff -r bc9245d02338ac13d7b3ca552c6e0bbd87bba65d https://code.google.com/p/go #

Patch Set 4 : diff -r 3d5b33a2459d4aeced21dde23f072cd1c5919059 https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/pkg/runtime/env_plan9.go	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

0intro

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2014-09-02 11:35:28 UTC) #1

bradfitz

https://codereview.appspot.com/137920044/diff/40001/src/pkg/runtime/env_plan9.go File src/pkg/runtime/env_plan9.go (right): https://codereview.appspot.com/137920044/diff/40001/src/pkg/runtime/env_plan9.go#newcode35 src/pkg/runtime/env_plan9.go:35: return "" I assume you'll still want to close(fd) ...

10 years, 6 months ago (2014-09-02 15:09:06 UTC) #2

0intro

Hello rsc@golang.org, bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

10 years, 6 months ago (2014-09-02 15:12:32 UTC) #3

0intro

Hello rsc@golang.org, bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

10 years, 6 months ago (2014-09-02 22:39:16 UTC) #6

0intro

10 years, 6 months ago (2014-09-02 22:56:40 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=2e244bd02014 ***

runtime: handle empty environment variables on Plan 9

LGTM=bradfitz, rsc
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/137920044

Expand All Messages | Collapse All Messages