Issue 13787043: provider/openstack: bug #1226996 SecurityGroup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13787043: provider/openstack: bug #1226996 SecurityGroup

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by gz

Modified:
10 years, 8 months ago

Reviewers:
mp+186586, rog

Visibility:
Public.

Description

provider/openstack: bug #1226996 SecurityGroup We intended to allow access to any port for any instance in the default security group. However, we didn't specify a CIDR and we didn't reference the Source Group Id. Which meant we actually were exposing *all* ports to *all* machines. This is a cherrypick from 1.14 rather than a merge up of all changes, as the two branches are surprisingly diverged. https://code.launchpad.net/~gz/juju-core/trunk-security-group-group-id-1226996/+merge/186586 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+144 lines, -9 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	provider/openstack/export_test.go	View	3 chunks	+24 lines, -0 lines	0 comments	Download
M	provider/openstack/live_test.go	View	2 chunks	+84 lines, -0 lines	0 comments	Download
M	provider/openstack/provider.go	View	4 chunks	+30 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rog

10 years, 8 months ago (2013-09-19 17:01:17 UTC) #2

On 2013/09/19 16:59:34, gz wrote:
> Please take a look.

LGTM assuming you've tested it live and the expose logic works
as expected.

Expand All Messages | Collapse All Messages