Issue 13786046: More renaming in preparation for bundle tokens.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by benji

Modified:
10 years, 7 months ago

Reviewers:
bac, mp+186776

Visibility:
Public.

Description

More renaming in preparation for bundle tokens. This branch consists primarily of removing more "charm" from "charm token". The only non-mechanical changes are in app/widgets/token.js. https://code.launchpad.net/~benji/juju-gui/more-charm-token-renaming/+merge/186776 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : More renaming in preparation for bundle tokens. #

Patch Set 3 : More renaming in preparation for bundle tokens. #

Patch Set 4 : More renaming in preparation for bundle tokens. #

Patch Set 5 : More renaming in preparation for bundle tokens. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -42 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/views/charm.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	app/subapps/browser/views/charmresults.js	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	app/subapps/browser/views/editorial.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	app/subapps/browser/views/search.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	app/templates/charm-token.handlebars	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	app/templates/token-container.handlebars	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/views/topology/service.js	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	app/widgets/charm-container.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	app/widgets/charm-token.js	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/views/browser/bws-searchbox.less	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/views/browser/main.less	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/views/browser/token.less	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/views/browser/token-container.less	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/test_browser_charm_details.js	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/test_browser_editorial.js	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/test_browser_search_view.js	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/test_browser_search_widget.js	View	1 2 3 4	4 chunks	+5 lines, -5 lines	0 comments	Download
M	test/test_charm_container.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_charm_running.py	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_charm_token.js	View	1 2 3 4	4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/test_charm_token_drag_and_drop.js	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/test_model.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_service_module.js	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bac

LGTM. Sorry for the grammar-nit that you didn't write. https://codereview.appspot.com/13786046/diff/1/app/widgets/charm-search.js File app/widgets/charm-search.js (right): https://codereview.appspot.com/13786046/diff/1/app/widgets/charm-search.js#newcode280 app/widgets/charm-search.js:280: ...

10 years, 7 months ago (2013-09-20 12:58:44 UTC) #2

benji

Thanks for the review. https://codereview.appspot.com/13786046/diff/1/app/widgets/charm-search.js File app/widgets/charm-search.js (right): https://codereview.appspot.com/13786046/diff/1/app/widgets/charm-search.js#newcode280 app/widgets/charm-search.js:280: // Stop clicking on tokens ...

10 years, 7 months ago (2013-09-20 13:06:09 UTC) #3

benji

*** Submitted: More renaming in preparation for bundle tokens. This branch consists primarily of removing ...

10 years, 7 months ago (2013-09-20 13:35:40 UTC) #4

benji

10 years, 7 months ago (2013-09-23 15:56:49 UTC) #5

*** Submitted:

More renaming in preparation for bundle tokens.

This branch consists primarily of removing more "charm" from "charm token".
The only non-mechanical changes are in app/widgets/token.js.

R=
CC=
https://codereview.appspot.com/13786046

Expand All Messages | Collapse All Messages