Issue 137830043: code review 137830043: image/png: do not apply filters if level is NoCompression

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 137830043: code review 137830043: image/png: do not apply filters if level is NoCompression (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by ruiu

Modified:
10 years, 8 months ago

Reviewers:
nigeltao

CC:
nigeltao, golang-codereviews

Visibility:
Public.

Description

image/png: do not apply filters if level is NoCompression PNG filters are applied to get better compression ratio. It does not make sense to apply them if we are not going to compress.

Patch Set 1 #

Patch Set 2 : diff -r af98bb1ca0570de13d2e2daad9951629938bae07 https://code.google.com/p/go #

Patch Set 3 : diff -r af98bb1ca0570de13d2e2daad9951629938bae07 https://code.google.com/p/go #

Patch Set 4 : diff -r af98bb1ca0570de13d2e2daad9951629938bae07 https://code.google.com/p/go #

Patch Set 5 : diff -r af98bb1ca0570de13d2e2daad9951629938bae07 https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	src/pkg/image/png/writer.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	M	src/pkg/image/png/writer_test.go	View	1 2 3	1 chunk	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ruiu

Hello nigeltao@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2014-08-28 15:35:32 UTC) #1

nigeltao

10 years, 8 months ago (2014-08-29 07:18:01 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=c37fc54f7e20 ***

image/png: do not apply filters if level is NoCompression

PNG filters are applied to get better compression ratio.
It does not make sense to apply them if we are not going
to compress.

LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://codereview.appspot.com/137830043

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages