Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4644)

Issue 13780044: environs/configstore: move interface from environs

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rog
Modified:
10 years, 7 months ago
Reviewers:
mp+186744, natefinch
Visibility:
Public.

Description

environs/configstore: move interface from environs This saves cyclic dependencies in an upcoming branch. https://code.launchpad.net/~rogpeppe/juju-core/407-configstore-move-interface/+merge/186744 Requires: https://code.launchpad.net/~rogpeppe/juju-core/405-configstore-fix-dir/+merge/186725 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/configstore: move interface from environs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -73 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/configstore/disk.go View 7 chunks +19 lines, -20 lines 0 comments Download
M environs/configstore/disk_test.go View 5 chunks +6 lines, -7 lines 0 comments Download
M environs/configstore/interface.go View 2 chunks +3 lines, -3 lines 0 comments Download
M environs/configstore/interface_test.go View 5 chunks +13 lines, -13 lines 0 comments Download
M environs/configstore/mem.go View 5 chunks +8 lines, -9 lines 0 comments Download
M environs/configstore/mem_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M juju/api.go View 2 chunks +2 lines, -2 lines 0 comments Download
M juju/apiconn_test.go View 10 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 2
rog
Please take a look.
10 years, 7 months ago (2013-09-20 10:40:26 UTC) #1
natefinch
10 years, 7 months ago (2013-09-20 10:42:25 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b