Replace internal_get_property with get_property where possible

Replace internal_get_property with get_property where possible

Note that thanks to lily-guile-macros magic, we can use get_property
with both string and SCM input (see lily/include/lily-guile-macros.hh:48).

[janek, 2014-08-27 16:07:45]

rebase on current master

[dak, 2014-09-02 13:33:02]

Oh shucks.  Another comment that has been leftover in Draft mode.  I have no
idea whether the concern voiced in it is valid.

https://codereview.appspot.com/137760043/diff/1/lily/engraver-group.cc
File lily/engraver-group.cc (right):

https://codereview.appspot.com/137760043/diff/1/lily/engraver-group.cc#newcode99
lily/engraver-group.cc:99: SCM meta = info.grob ()->get_property ("meta");
I'm not sure whether meta lookups would be wanted in the statistics when we have
the stat-collection enabled.

[dak, 2014-09-02 13:45:45]

So I went through a review after all and found a few niggles that seem worth
fixing.  Probably does not require a full countdown and stuff, but another
patchy run might be warranted in order to avoid typos.

https://codereview.appspot.com/137760043/diff/20001/lily/grob.cc
File lily/grob.cc (right):

https://codereview.appspot.com/137760043/diff/20001/lily/grob.cc#newcode470
lily/grob.cc:470: SCM min_ext = get_property (min_ext_name);
This one is bad since it breaks memoization.  Either leave it alone or do
(properly formatted)
SCM min_ext = a == X_AXIS ? get_property ("minimum-X-extent") : get_property
("minimum-Y-extent")

https://codereview.appspot.com/137760043/diff/20001/lily/self-alignment-inter...
File lily/self-alignment-interface.cc (right):

https://codereview.appspot.com/137760043/diff/20001/lily/self-alignment-inter...
lily/self-alignment-interface.cc:54: SCM align (me->get_property (sym));
See above.

https://codereview.appspot.com/137760043/diff/20001/lily/self-alignment-inter...
lily/self-alignment-interface.cc:125: ? me->get_property ("self-alignment-X")
Here you do it properly!

https://codereview.appspot.com/137760043/diff/20001/lily/span-bar-engraver.cc
File lily/span-bar-engraver.cc (right):

https://codereview.appspot.com/137760043/diff/20001/lily/span-bar-engraver.cc...
lily/span-bar-engraver.cc:85: SCM vis = bars_[0]->get_property
("break-visibility");
This causes the symbol to be memoized three times in a row.  However, only the
first time the code is being run, so I'd say never mind.  The readability should
be worth it.

[janek, 2014-09-03 22:33:23]

fix memoization

[janek, 2014-09-03 22:42:26]

Hi,

On 2014/09/02 13:45:45, dak wrote:
> So I went through a review after all and found a few niggles that seem worth
> fixing.  Probably does not require a full countdown and stuff, but another
> patchy run might be warranted in order to avoid typos.

Thanks for reviewing, and for giving me green light for pushing without next
full countdown (i take this as a sign of trust).  However, considering how my
recent patches tended to have problems, i'll leave it for a full cycle,
especially that i'm not in hurry with this one.

https://codereview.appspot.com/137760043/diff/1/lily/engraver-group.cc
File lily/engraver-group.cc (right):

https://codereview.appspot.com/137760043/diff/1/lily/engraver-group.cc#newcode99
lily/engraver-group.cc:99: SCM meta = info.grob ()->get_property ("meta");
On 2014/09/02 13:33:02, dak wrote:
> I'm not sure whether meta lookups would be wanted in the statistics when we
have
> the stat-collection enabled.

Hmm.  I don't know either.  I'd really like to get rid of internal_get_property
where possible (so that no one will be confused as i was), but maybe here it'd
be better to err on the safe side...

https://codereview.appspot.com/137760043/diff/20001/lily/grob.cc
File lily/grob.cc (right):

https://codereview.appspot.com/137760043/diff/20001/lily/grob.cc#newcode470
lily/grob.cc:470: SCM min_ext = get_property (min_ext_name);
On 2014/09/02 13:45:44, dak wrote:
> This one is bad since it breaks memoization.  Either leave it alone or do
> (properly formatted)
> SCM min_ext = a == X_AXIS ? get_property ("minimum-X-extent") : get_property
> ("minimum-Y-extent")

Done.

https://codereview.appspot.com/137760043/diff/20001/lily/self-alignment-inter...
File lily/self-alignment-interface.cc (right):

https://codereview.appspot.com/137760043/diff/20001/lily/self-alignment-inter...
lily/self-alignment-interface.cc:54: SCM align (me->get_property (sym));
On 2014/09/02 13:45:45, dak wrote:
> See above.

Done.

https://codereview.appspot.com/137760043/diff/20001/lily/self-alignment-inter...
lily/self-alignment-interface.cc:125: ? me->get_property ("self-alignment-X")
On 2014/09/02 13:45:45, dak wrote:
> Here you do it properly!

Acknowledged.

https://codereview.appspot.com/137760043/diff/20001/lily/span-bar-engraver.cc
File lily/span-bar-engraver.cc (right):

https://codereview.appspot.com/137760043/diff/20001/lily/span-bar-engraver.cc...
lily/span-bar-engraver.cc:85: SCM vis = bars_[0]->get_property
("break-visibility");
On 2014/09/02 13:45:45, dak wrote:
> This causes the symbol to be memoized three times in a row.  However, only the
> first time the code is being run, so I'd say never mind.  The readability
should
> be worth it.

Acknowledged.

[janek, 2014-09-08 06:51:11]

pushed as

commit 3dfd0a47e01374e0d8d1e6b127fa3f7a15a53edc
Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
Date:   Thu Aug 21 18:34:22 2014 +0200

    Replace internal_get_property with get_property where possible
    
    Note that thanks to lily-guile-macros magic, we can use get_property
    with both string and SCM input (see lily/include/lily-guile-macros.hh:48).