Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1913)

Issue 13772043: Add support for export via icon.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by bac
Modified:
10 years, 7 months ago
Reviewers:
mp+186456, jeff.pihach
Visibility:
Public.

Description

Add support for export via icon. https://code.launchpad.net/~bac/juju-gui/import-icon/+merge/186456 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add support for export via icon. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 3 chunks +22 lines, -5 lines 0 comments Download
A app/assets/images/icon_export.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/icon_import.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/import.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/index.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
10 years, 7 months ago (2013-09-19 02:35:09 UTC) #1
jeff.pihach
Code looks good with just some trivial markup/css changes. During the QA I exported then ...
10 years, 7 months ago (2013-09-19 02:45:48 UTC) #2
jeff.pihach
LGTM as the export/import issue is pre-existing.
10 years, 7 months ago (2013-09-19 02:48:40 UTC) #3
bac
Thanks for the review Jeff. Good suggestion on the cursor.
10 years, 7 months ago (2013-09-19 13:03:46 UTC) #4
bac
10 years, 7 months ago (2013-09-19 13:25:02 UTC) #5
*** Submitted:

Add support for export via icon.

R=jeff.pihach
CC=
https://codereview.appspot.com/13772043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b