Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1669)

Issue 13771047: Use Fakebackend API to perform deployer imports

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by bcsaller
Modified:
7 years ago
Reviewers:
mp+186646, jeff.pihach
Visibility:
Public.

Description

Use Fakebackend API to perform deployer imports This branch, rather than direct database manipulation uses the fackbackend API methods to build out its virutal deployments. This also removes support the old improv import Environment which has no UI bound to it currently ( as import/export are now deployer oriented). As a minor this changes the policy around relation displayNames such that on the canvas we see both names by default (that would be a one liner to revert) and displays the actual endpoint name on the relations tab rather than just one of them. https://code.launchpad.net/~bcsaller/juju-gui/importDeployerRedux/+merge/186646 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 20

Patch Set 2 : Use Fakebackend API to perform deployer imports #

Patch Set 3 : Use Fakebackend API to perform deployer imports #

Patch Set 4 : Use Fakebackend API to perform deployer imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+613 lines, -1878 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/models.js View 3 chunks +10 lines, -344 lines 0 comments Download
M app/store/env/fakebackend.js View 1 2 10 chunks +344 lines, -166 lines 0 comments Download
M app/templates/service-relations-list.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/views/topology/relation.js View 2 chunks +1 line, -7 lines 0 comments Download
D test/data/large-improv.json View 1 chunk +0 lines, -398 lines 0 comments Download
D test/data/openstack-improv.json View 1 chunk +0 lines, -396 lines 0 comments Download
D test/data/sample-improv.json View 1 chunk +0 lines, -187 lines 0 comments Download
M test/data/wp-deployer.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/test_bundle_module.js View 1 2 3 5 chunks +12 lines, -16 lines 0 comments Download
M test/test_fakebackend.js View 1 4 chunks +192 lines, -137 lines 0 comments Download
M test/test_model.js View 1 chunk +0 lines, -175 lines 0 comments Download
M test/test_sandbox_python.js View 4 chunks +6 lines, -32 lines 0 comments Download
M test/test_simulator.js View 3 chunks +7 lines, -7 lines 0 comments Download
M test/test_topology.js View 1 chunk +5 lines, -11 lines 0 comments Download
M test/utils.js View 1 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 6
bcsaller
Please take a look.
7 years ago (2013-09-19 20:31:41 UTC) #1
gary.poster
Incomplete review. Sorry https://codereview.appspot.com/13771047/diff/1/app/models/models.js File app/models/models.js (left): https://codereview.appspot.com/13771047/diff/1/app/models/models.js#oldcode774 app/models/models.js:774: Takes two string endpoints and splits ...
7 years ago (2013-09-19 21:12:08 UTC) #2
benjamin.saller
Pushed the reject deploy failure change as requested. I can repropose if need be. https://codereview.appspot.com/13771047/diff/1/app/store/env/fakebackend.js ...
7 years ago (2013-09-19 21:36:27 UTC) #3
benjamin.saller
Added some reviewer notes https://codereview.appspot.com/13771047/diff/1/app/models/models.js File app/models/models.js (left): https://codereview.appspot.com/13771047/diff/1/app/models/models.js#oldcode774 app/models/models.js:774: Takes two string endpoints and ...
7 years ago (2013-09-19 21:55:38 UTC) #4
jeff.pihach
LGTM with some trivials QA OK Tested on Go sandbox and Rapi (it showed the ...
7 years ago (2013-09-20 16:59:44 UTC) #5
bcsaller
7 years ago (2013-09-20 18:08:15 UTC) #6
*** Submitted:

Use Fakebackend API to perform deployer imports

This branch, rather than direct database manipulation uses the fackbackend 
API methods to build out its virutal deployments. This also removes support
the old improv import Environment which has no UI bound to it currently (
as import/export are now deployer oriented).

As a minor this changes the policy around relation displayNames such that
on the canvas we see both names by default (that would be a one liner to 
revert) and displays the actual endpoint name on the relations tab rather
than just one of them.

R=gary.poster, benjamin.saller, jeff.pihach
CC=
https://codereview.appspot.com/13771047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b