Deprecate public-bucket-url

Deprecate public-bucket-url

public-bucket-url is deprecated in favour of using
tools-url and image-metadata-url. Bootstrapping with 
configs which have this setting specified will print
a deprecation warning and set the tools-url to the
expected value.

Canonistack no longer needs public-bucket-url at all
because a keystone endpoint is defined. For HP Cloud,
the next branch will include a lookup for the correct
tools url so public bucket is not needed there either.

https://code.launchpad.net/~wallyworld/juju-core/deprecate-public-bucket-url/+merge/186691

(do not edit description out of merge proposal)

[wallyworld, 2013-09-19 23:36:22]

Please take a look.

[thumper, 2013-09-20 01:55:39]

https://codereview.appspot.com/13763044/diff/1/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (right):

https://codereview.appspot.com/13763044/diff/1/environs/jujutest/livetests.go...
environs/jujutest/livetests.go:501: err := stor.Put("bootstrap-verify",
contentReader,
Don't we have a helper method in the bootstrap code that does this?  Just
wondering.

https://codereview.appspot.com/13763044/diff/1/environs/testing/tools.go
File environs/testing/tools.go (right):

https://codereview.appspot.com/13763044/diff/1/environs/testing/tools.go#newc...
environs/testing/tools.go:74: path := filepath.Join("tools", object.path)
We've recently been bitten by using filepath over path.  If the path is for a
URL, then we should always be using path.Join.

https://codereview.appspot.com/13763044/diff/1/provider/openstack/config.go
File provider/openstack/config.go (right):

https://codereview.appspot.com/13763044/diff/1/provider/openstack/config.go#n...
provider/openstack/config.go:130: logger.Warningf(msg)
\o/

https://codereview.appspot.com/13763044/diff/1/provider/openstack/provider.go
File provider/openstack/provider.go (right):

https://codereview.appspot.com/13763044/diff/1/provider/openstack/provider.go...
provider/openstack/provider.go:106: tools-url:
https://region-a.geo-1.objects.hpcloudsvc.com:443/v1/60502529753910/juju-dist...
Why add :443 here?

[wallyworld, 2013-09-20 02:06:38]

Please take a look.

https://codereview.appspot.com/13763044/diff/1/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (right):

https://codereview.appspot.com/13763044/diff/1/environs/jujutest/livetests.go...
environs/jujutest/livetests.go:501: err := stor.Put("bootstrap-verify",
contentReader,
On 2013/09/20 01:55:40, thumper wrote:
> Don't we have a helper method in the bootstrap code that does this?  Just
> wondering.

No idea. I was just drive by fixing a variable name in existing code.

https://codereview.appspot.com/13763044/diff/1/environs/testing/tools.go
File environs/testing/tools.go (right):

https://codereview.appspot.com/13763044/diff/1/environs/testing/tools.go#newc...
environs/testing/tools.go:74: path := filepath.Join("tools", object.path)
On 2013/09/20 01:55:40, thumper wrote:
> We've recently been bitten by using filepath over path.  If the path is for a
> URL, then we should always be using path.Join.

Done.

https://codereview.appspot.com/13763044/diff/1/provider/openstack/provider.go
File provider/openstack/provider.go (right):

https://codereview.appspot.com/13763044/diff/1/provider/openstack/provider.go...
provider/openstack/provider.go:106: tools-url:
https://region-a.geo-1.objects.hpcloudsvc.com:443/v1/60502529753910/juju-dist...
On 2013/09/20 01:55:40, thumper wrote:
> Why add :443 here?

What was there didn't work for some reason - I tested it. I used the HP Cloud
console to get the correct URL and copied it in here.

[thumper, 2013-09-20 03:24:22]

On 2013/09/20 02:06:38, wallyworld wrote:
> Please take a look.
> 
> https://codereview.appspot.com/13763044/diff/1/environs/jujutest/livetests.go
> File environs/jujutest/livetests.go (right):
> 
>
https://codereview.appspot.com/13763044/diff/1/environs/jujutest/livetests.go...
> environs/jujutest/livetests.go:501: err := stor.Put("bootstrap-verify",
> contentReader,
> On 2013/09/20 01:55:40, thumper wrote:
> > Don't we have a helper method in the bootstrap code that does this?  Just
> > wondering.
> 
> No idea. I was just drive by fixing a variable name in existing code.
> 
> https://codereview.appspot.com/13763044/diff/1/environs/testing/tools.go
> File environs/testing/tools.go (right):
> 
>
https://codereview.appspot.com/13763044/diff/1/environs/testing/tools.go#newc...
> environs/testing/tools.go:74: path := filepath.Join("tools", object.path)
> On 2013/09/20 01:55:40, thumper wrote:
> > We've recently been bitten by using filepath over path.  If the path is for
a
> > URL, then we should always be using path.Join.
> 
> Done.
> 
> https://codereview.appspot.com/13763044/diff/1/provider/openstack/provider.go
> File provider/openstack/provider.go (right):
> 
>
https://codereview.appspot.com/13763044/diff/1/provider/openstack/provider.go...
> provider/openstack/provider.go:106: tools-url:
>
https://region-a.geo-1.objects.hpcloudsvc.com:443/v1/60502529753910/juju-dist...
> On 2013/09/20 01:55:40, thumper wrote:
> > Why add :443 here?
> 
> What was there didn't work for some reason - I tested it. I used the HP Cloud
> console to get the correct URL and copied it in here.

LGTM