Issue 13761047: code review 13761047: go.text/encoding/simplifiedchinese: implement GB18030.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13761047: code review 13761047: go.text/encoding/simplifiedchinese: implement GB18030. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by nigeltao

Modified:
11 years, 10 months ago

Reviewers:
r

CC:
r, andybalholm, golang-dev, mpvl, rog

Visibility:
Public.

Description

go.text/encoding/simplifiedchinese: implement GB18030. GB18030 is a superset of GBK. I'm not entirely sure why GBK decoding got 6% faster; I'm just happy that there aren't any big regressions. benchmark old MB/s new MB/s speedup BenchmarkGBKDecoder 116.96 123.64 1.06x BenchmarkGBKEncoder 179.31 176.86 0.99x

Patch Set 1 #

Patch Set 2 : diff -r b453ef7b57ca https://code.google.com/p/go.text #

Patch Set 3 : diff -r b453ef7b57ca https://code.google.com/p/go.text #

Patch Set 4 : diff -r b453ef7b57ca https://code.google.com/p/go.text #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+917 lines, -35 lines)			Patch
M	encoding/encoding_test.go	View	1 2 3	4 chunks	+38 lines, -9 lines	0 comments	Download
M	encoding/simplifiedchinese/gbk.go	View	1	7 chunks	+128 lines, -26 lines	0 comments	Download
M	encoding/simplifiedchinese/maketables.go	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	encoding/simplifiedchinese/tables.go	View	1	1 chunk	+210 lines, -0 lines	0 comments	Download
A	encoding/testdata/candide-gb18030.txt	View	1 2 3	1 chunk	+510 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: andybalholm@gmail.com, golang-dev@googlegroups.com, mpvl@golang.org, rogpeppe@gmail.com), I'd like you to review this change to ...

11 years, 10 months ago (2013-09-24 01:32:23 UTC) #1

nigeltao

11 years, 10 months ago (2013-09-24 01:45:34 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=e4135795422e&repo=text ***

go.text/encoding/simplifiedchinese: implement GB18030.

GB18030 is a superset of GBK. I'm not entirely sure why GBK decoding
got 6% faster; I'm just happy that there aren't any big regressions.

benchmark                     old MB/s     new MB/s  speedup
BenchmarkGBKDecoder             116.96       123.64    1.06x
BenchmarkGBKEncoder             179.31       176.86    0.99x

R=r
CC=andybalholm, golang-dev, mpvl, rogpeppe
https://codereview.appspot.com/13761047

Expand All Messages | Collapse All Messages