Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(112)

Issue 13760044: code review 13760044: all: Fix a couple of issues reported by go vet. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by u
Modified:
12 years, 7 months ago
Reviewers:
r, golang-dev
CC:
golang-dev
Visibility:
Public.

Description

all: Fix a couple of issues reported by go vet.

Patch Set 1 #

Patch Set 2 : diff -r c5ba4a636f44 https://code.google.com/p/go #

Patch Set 3 : diff -r c5ba4a636f44 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 954eee4cdc5e https://code.google.com/p/go #

Patch Set 5 : diff -r 954eee4cdc5e https://code.google.com/p/go #

Patch Set 6 : diff -r ebd02fba267b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M src/pkg/encoding/gob/encoder_test.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/big/int_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/header_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/ip_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/timeout_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/reflect/all_test.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/runtime/crash_test.go View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/syscall/exec_linux.go View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6
u
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 7 months ago (2013-09-19 23:52:06 UTC) #1
r
https://codereview.appspot.com/13760044/diff/6001/src/pkg/net/http/header_test.go File src/pkg/net/http/header_test.go (right): https://codereview.appspot.com/13760044/diff/6001/src/pkg/net/http/header_test.go#newcode207 src/pkg/net/http/header_test.go:207: t.Errorf("mallocs = %d; want 0", uint64(n)) t.Errorf("mallocs = %g; ...
12 years, 7 months ago (2013-09-20 00:45:23 UTC) #2
u
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 7 months ago (2013-09-20 09:37:55 UTC) #3
r
LGTM but apologies for the delay and what it causes - please sync to tip ...
12 years, 7 months ago (2013-09-26 03:04:27 UTC) #4
u
On 2013/09/26 03:04:27, r wrote: > LGTM > > but apologies for the delay and ...
12 years, 7 months ago (2013-09-27 15:35:26 UTC) #5
r
12 years, 7 months ago (2013-09-27 20:48:07 UTC) #6
Just hg clpatch the old CL number on the new machine, but if there was
still a chunk mismatch that would be a problem....

-rob
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b