Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(272)

Issue 13751045: code review 13751045: cmd/ld: fix "ld -s" to not discard pclntab. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by minux1
Modified:
4 years, 2 months ago
Reviewers:
rsc, bradfitz
CC:
golang-dev, bradfitz, rsc
Visibility:
Public.

Description

cmd/ld: fix "ld -s" to not discard pclntab. Fixes issue 6245.

Patch Set 1 #

Patch Set 2 : diff -r c5ba4a636f44 https://code.google.com/p/go #

Patch Set 3 : diff -r c5ba4a636f44 https://code.google.com/p/go #

Patch Set 4 : diff -r 954eee4cdc5e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/cmd/ld/lib.c View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
4 years, 2 months ago (2013-09-20 03:48:32 UTC) #1
bradfitz
LGTM On Fri, Sep 20, 2013 at 4:48 AM, <minux.ma@gmail.com> wrote: > Reviewers: golang-dev1, > ...
4 years, 2 months ago (2013-09-20 07:30:14 UTC) #2
rsc
LGTM
4 years, 2 months ago (2013-09-20 13:41:04 UTC) #3
minux1
4 years, 2 months ago (2013-09-20 14:04:58 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=d5f023ae1d0e ***

cmd/ld: fix "ld -s" to not discard pclntab.
Fixes issue 6245.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://codereview.appspot.com/13751045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4