Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2309)

Issue 13747043: Use green checkmark for save indicator

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by gary.poster
Modified:
10 years, 7 months ago
Reviewers:
mp+186162, benji
Visibility:
Public.

Description

Use green checkmark for save indicator It fades in chrome, and merely turns off after a second in FF (and hopefully IE10). https://code.launchpad.net/~gary/juju-gui/checkmarkSave/+merge/186162 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Use green checkmark for save indicator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/field-saved-finished.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M lib/views/juju-inspector.less View 1 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 3
gary.poster
Please take a look.
10 years, 7 months ago (2013-09-17 20:57:34 UTC) #1
benji
Code LGTM, no QA.
10 years, 7 months ago (2013-09-17 21:01:40 UTC) #2
gary.poster
10 years, 7 months ago (2013-09-17 21:17:22 UTC) #3
*** Submitted:

Use green checkmark for save indicator

It fades in chrome, and merely turns off after a second in FF (and hopefully
IE10).

R=benji
CC=
https://codereview.appspot.com/13747043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b