Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2023)

Issue 13738043: Add support for the EGL_CHROMIUM_sync_control extension

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by John Bauman
Modified:
10 years, 7 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/angle.git@master
Visibility:
Public.

Description

Add support for the EGL_CHROMIUM_sync_control extension This is essentially just a version of glXGetSyncValuesOML from GLX_OML_sync_control, and is used on Chrome OS to determine when the last vsync occurred. The implementation estimates the last vsync time based on the current scanline position. BUG=

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -0 lines) Patch
M include/EGL/eglext.h View 1 chunk +15 lines, -0 lines 1 comment Download
M src/libEGL/Display.cpp View 1 chunk +5 lines, -0 lines 1 comment Download
M src/libEGL/Surface.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/libEGL/Surface.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/libEGL/libEGL.cpp View 2 chunks +28 lines, -0 lines 1 comment Download
M src/libGLESv2/renderer/Renderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/renderer/Renderer11.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/renderer/Renderer11.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/libGLESv2/renderer/Renderer9.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/renderer/Renderer9.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/libGLESv2/renderer/SwapChain.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/libGLESv2/renderer/SwapChain11.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/renderer/SwapChain11.cpp View 1 chunk +4 lines, -0 lines 2 comments Download
M src/libGLESv2/renderer/SwapChain9.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/libGLESv2/renderer/SwapChain9.cpp View 3 chunks +76 lines, -0 lines 3 comments Download

Messages

Total messages: 4
John Bauman
10 years, 7 months ago (2013-09-17 05:19:02 UTC) #1
Geoff Lang
If there is an extension spec, please add it to the extensions directory. Please also ...
10 years, 7 months ago (2013-09-17 14:04:31 UTC) #2
Jamie Madill
https://codereview.appspot.com/13738043/diff/1/src/libEGL/Display.cpp File src/libEGL/Display.cpp (right): https://codereview.appspot.com/13738043/diff/1/src/libEGL/Display.cpp#newcode507 src/libEGL/Display.cpp:507: mExtensionString += "EGL_CHROMIUM_sync_control"; whitespace error on indent here https://codereview.appspot.com/13738043/diff/1/src/libGLESv2/renderer/SwapChain11.cpp ...
10 years, 7 months ago (2013-09-17 14:16:09 UTC) #3
Shannon Woods
10 years, 7 months ago (2013-09-17 19:05:17 UTC) #4
https://codereview.appspot.com/13738043/diff/1/include/EGL/eglext.h
File include/EGL/eglext.h (right):

https://codereview.appspot.com/13738043/diff/1/include/EGL/eglext.h#newcode364
include/EGL/eglext.h:364: 
If we're going to diverge eglext.h from the canonical version, I'd rather not do
so with an out-of-date version of the file.

Alternatively, the extension could be published and included in the canonical
eglext.h.

https://codereview.appspot.com/13738043/diff/1/src/libEGL/libEGL.cpp
File src/libEGL/libEGL.cpp (right):

https://codereview.appspot.com/13738043/diff/1/src/libEGL/libEGL.cpp#newcode1155
src/libEGL/libEGL.cpp:1155: EGLuint64CHROMIUM *msc, EGLuint64CHROMIUM *sbc)
Please indent this to the level where arguments begin on the previous line.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b