Issue 13735043: code review 13735043: runtime: export PCDATA value reader

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13735043: code review 13735043: runtime: export PCDATA value reader (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by cshapiro

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: export PCDATA value reader This interface is required to use the PCDATA interface implemented in Go 1.2. While initially entirely private, the FUNCDATA side of the interface has been made public. This change completes the FUNCDATA/PCDATA interface.

Patch Set 1 #

Patch Set 2 : diff -r 84e8898f7eca https://code.google.com/p/go/ #

Patch Set 3 : diff -r 84e8898f7eca https://code.google.com/p/go/ #

Patch Set 4 : diff -r 84e8898f7eca https://code.google.com/p/go/ #

Patch Set 5 : diff -r c111e30c49a4 https://code.google.com/p/go/ #

Patch Set 6 : diff -r c111e30c49a4 https://code.google.com/p/go/ #

Patch Set 7 : diff -r c111e30c49a4 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/pkg/runtime/runtime.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/runtime/symtab.c	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

cshapiro

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-09-17 00:44:56 UTC) #1

cshapiro

11 years, 7 months ago (2013-09-17 02:03:22 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4bbc6356e4ec ***

runtime: export PCDATA value reader

This interface is required to use the PCDATA interface
implemented in Go 1.2.  While initially entirely private, the
FUNCDATA side of the interface has been made public.  This
change completes the FUNCDATA/PCDATA interface.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13735043

Expand All Messages | Collapse All Messages