Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(836)

Issue 13728043: ns-3 GSoC 2013 (LTE) - Proposed merge

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by buherman
Modified:
10 years, 6 months ago
Reviewers:
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Hi, This is the standard set of deliverables of the ns-3 GSoC 2013 project, LTE UE measurements. It includes: - the latest lena-dev repository (revision 10195 as the tip, dated Friday 13th of September); - ns-3-dev changes up to revision 10192 (dated Friday 6th of September); and - all the changes made by the project from the beginning until the pencil-down week (up to Monday 16th of September). === UPDATE (25th of September). Added Patch Set 2, which is the final set of deliverables of the project. It's based on revision 10205 of ns-3-dev [1] and revision 10059 of GSoC repository [2]. If you want to download it, please clone it directly from the merged repository [3] where this patch set originates from. === UPDATE (23rd of October). Added Patch Set 3, which is a merge of ns-3-dev revision 10224 and GSoC repository revision 10074. This includes the result of the final code review [4]. The aim of the review is to merge the deliverables to ns-3-dev and lena-dev repository. For reviewing purpose, please also check another Rietveld issue [4] which is intended for a more convenient review. The patch set below contains a lot of files, which I'll briefly introduce here. The files under `src/lte/doc/` are related to the updated LTE model library documentation text (*.rst) and figures (*.dia, *.eps, *.dot, *.png, *.pdf). The compiled version are also available for review in HTML [5] and PDF [6] formats. The most relevant sections for the project are: - Design Documentation > RRC > Initial Cell Selection; - Design Documentation > RRC > UE RRC Measurements Model; - Design Documentation > RRC > Handover; - Design Documentation > RRC > Neighbour Relation; - User Documentation > Network Attachment; - User Documentation > Configure UE measurements; - User Documentation > X2-based handover; - User Documentation > Reference scenarios > Handover simulation campaign; - Testing Documentation > UE measurement configuration tests; - Testing Documentation > Initial cell selection; and - Testing Documentation > Selection of target cell in handover algorithm. The files under `src/lte/model/` are the main code. In overview, these files can be grouped as follows: - related to UE measurements function: - lte-rrc-sap.* (data types) - lte-common.* (conversion functions) - lte-enb-rrc.* - lte-ue-rrc.* - related to System Information Block Type 1 (SIB1): - lte-control-messages.* (message type) - lte-enb-rrc.* - lte-enb-cphy-sap.* (RRC-PHY interface) - lte-enb-phy.* - lte-rrc-protocol-ideal.* (old RRC-RRC interface) - lte-rrc-protocol-real.* (old RRC-RRC interface) - lte-rrc-sap.* (new RRC-RRC interface) - lte-ue-cphy-sap.* (PHY-RRC interface) - lte-ue-rrc.* - related to Idle mode initial cell selection function: - lte-rrc-sap.* (data types) - epc-ue-nas.* - lte-as-sap.* (NAS-RRC interface) - lte-ue-cphy-sap.* (RRC-PHY interface) - lte-ue-phy.* (cell search) - lte-ue-rrc.* - related to Handover Algorithm function: - lte-handover-algorithm.* (base class) - a2-a4-rsrq-handover-algorithm.* (legacy) - a3-rsrp-handover-algorithm.* (strongest cell) - no-op-handover-algorithm.* (disable handover algorithm) - lte-handover-management-sap.* (interface with RRC) - lte-enb-rrc.* - lte-enb-net-device.* - related to Automatic Neighbour Relation (ANR) function: - lte-anr-sap.* (interface with RRC) - lte-anr.* (ANR) - lte-enb-rrc.* - lte-enb-net-device.* The remaining files are helpers, examples, and tests: - lena-dual-stripe.cc (updated with initial cell selection) - lena-x2-handover-measures.cc (updated with handover algorithm) - lte-test-cell-selection.* (a test suite for initial cell selection) - lte-test-ue-measurements.* (3 new test suites related to UE measurements) - test-lte-handover-target.cc (a test suite for handover algorithm) - test-lte-x2-handover-measures.cc (updated with handover algorithm) Issue to note: some test results have indicated that when RRC connection establishment messages are lost, they are not re-transmitted. Hence the UE stays in IDLE_CONNECTING state forever. This is probably a bug and is currently under investigation. === UPDATE (17th September 2013). The above issue has become Bug 1762 [7]. Thanks for spending the time for reviewing. -budi- [1] http://code.nsnam.org/ns-3-dev/ [2] http://code.nsnam.org/buherman/ns-3-gsoc-lte/ [3] http://code.nsnam.org/buherman/ns-3-gsoc-lte-merge/ [4] https://codereview.appspot.com/13720052/ [5] http://www.nsnam.org/~buherman/sphinx_gsoc2013/html/lte.html [6] http://www.nsnam.org/~buherman/sphinx_gsoc2013/latex/ns-3-model-library.pdf [7] https://www.nsnam.org/bugzilla/show_bug.cgi?id=1762

Patch Set 1 #

Patch Set 2 : Updated patch set 25th September 2013 #

Patch Set 3 : Updated (22nd October 2013) after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17278 lines, -5540 lines) Patch
M doc/models/Makefile View 1 2 7 chunks +21 lines, -5 lines 0 comments Download
M src/lte/doc/Makefile View 1 2 6 chunks +15 lines, -8 lines 0 comments Download
A src/lte/doc/source/figures/lte-cell-selection-scenario.dia View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/lte-cell-selection-timeline.dia View 1 2 Binary file 0 comments Download
M src/lte/doc/source/figures/lte-enb-rrc-states.dot View 1 2 1 chunk +31 lines, -28 lines 0 comments Download
M src/lte/doc/source/figures/lte-enb-rrc-states.pdf View 1 2 Binary file 0 comments Download
M src/lte/doc/source/figures/lte-enb-rrc-states.png View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/lte-epc-x2-handover-seq-diagram.dia View 1 2 Binary file 0 comments Download
R src/lte/doc/source/figures/lte-epc-x2-handover-seq-diagram.eps View 1 2 1 chunk +0 lines, -2995 lines 0 comments Download
R src/lte/doc/source/figures/lte-handover-algorithm.pdf View 1 2 Binary file 0 comments Download
R src/lte/doc/source/figures/lte-handover-algorithm.png View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/lte-handover-campaign-rem.pdf View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/lte-handover-campaign-rem.png View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/lte-handover-target-scenario.dia View 1 2 Binary file 0 comments Download
M src/lte/doc/source/figures/lte-legacy-handover-algorithm.dot View 1 2 1 chunk +16 lines, -14 lines 0 comments Download
A src/lte/doc/source/figures/lte-legacy-handover-algorithm.pdf View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/lte-legacy-handover-algorithm.png View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/lte-strongest-cell-handover-algorithm.eps View 1 2 1 chunk +5124 lines, -0 lines 0 comments Download
M src/lte/doc/source/figures/lte-ue-rrc-states.dot View 1 2 1 chunk +31 lines, -16 lines 0 comments Download
M src/lte/doc/source/figures/lte-ue-rrc-states.pdf View 1 2 Binary file 0 comments Download
M src/lte/doc/source/figures/lte-ue-rrc-states.png View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/ue-meas-consumer.dia View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/ue-meas-piecewise-a1.dia View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/ue-meas-piecewise-a1-hys.dia View 1 2 Binary file 0 comments Download
A src/lte/doc/source/figures/ue-meas-piecewise-motion.dia View 1 2 Binary file 0 comments Download
M src/lte/doc/source/lte-design.rst View 1 2 33 chunks +734 lines, -161 lines 0 comments Download
M src/lte/doc/source/lte-references.rst View 1 2 3 chunks +64 lines, -34 lines 0 comments Download
M src/lte/doc/source/lte-testing.rst View 1 2 9 chunks +415 lines, -30 lines 0 comments Download
M src/lte/doc/source/lte-user.rst View 1 2 15 chunks +730 lines, -124 lines 0 comments Download
M src/lte/examples/lena-dual-stripe.cc View 1 2 23 chunks +123 lines, -116 lines 0 comments Download
M src/lte/examples/lena-x2-handover.cc View 1 2 8 chunks +89 lines, -91 lines 0 comments Download
M src/lte/examples/lena-x2-handover-measures.cc View 1 2 11 chunks +159 lines, -36 lines 0 comments Download
M src/lte/helper/lte-helper.h View 1 2 8 chunks +111 lines, -18 lines 0 comments Download
M src/lte/helper/lte-helper.cc View 1 2 24 chunks +131 lines, -26 lines 0 comments Download
A src/lte/model/a2-a4-rsrq-handover-algorithm.h View 1 2 1 chunk +152 lines, -0 lines 0 comments Download
A src/lte/model/a2-a4-rsrq-handover-algorithm.cc View 1 2 1 chunk +288 lines, -0 lines 0 comments Download
A src/lte/model/a3-rsrp-handover-algorithm.h View 1 2 1 chunk +114 lines, -0 lines 0 comments Download
A src/lte/model/a3-rsrp-handover-algorithm.cc View 1 2 1 chunk +193 lines, -0 lines 0 comments Download
M src/lte/model/epc-ue-nas.h View 1 2 3 chunks +59 lines, -24 lines 0 comments Download
M src/lte/model/epc-ue-nas.cc View 1 2 8 chunks +71 lines, -21 lines 0 comments Download
A src/lte/model/lte-anr.h View 1 2 1 chunk +233 lines, -0 lines 0 comments Download
A src/lte/model/lte-anr.cc View 1 2 1 chunk +263 lines, -0 lines 0 comments Download
A src/lte/model/lte-anr-sap.h View 1 2 1 chunk +233 lines, -0 lines 0 comments Download
A src/lte/model/lte-anr-sap.cc View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M src/lte/model/lte-as-sap.h View 1 2 7 chunks +58 lines, -25 lines 0 comments Download
M src/lte/model/lte-common.h View 1 2 6 chunks +91 lines, -21 lines 0 comments Download
M src/lte/model/lte-common.cc View 1 2 4 chunks +100 lines, -4 lines 0 comments Download
M src/lte/model/lte-control-messages.h View 1 2 11 chunks +71 lines, -130 lines 0 comments Download
M src/lte/model/lte-control-messages.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-cphy-sap.h View 1 2 3 chunks +14 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-net-device.h View 1 2 5 chunks +65 lines, -8 lines 0 comments Download
M src/lte/model/lte-enb-net-device.cc View 1 2 10 chunks +101 lines, -12 lines 0 comments Download
M src/lte/model/lte-enb-phy.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-phy.cc View 1 2 2 chunks +23 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-rrc.h View 1 2 17 chunks +159 lines, -84 lines 0 comments Download
M src/lte/model/lte-enb-rrc.cc View 1 2 35 chunks +410 lines, -325 lines 0 comments Download
A src/lte/model/lte-handover-algorithm.h View 1 2 1 chunk +111 lines, -0 lines 0 comments Download
A src/lte/model/lte-handover-algorithm.cc View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A src/lte/model/lte-handover-management-sap.h View 1 2 1 chunk +194 lines, -0 lines 0 comments Download
A src/lte/model/lte-handover-management-sap.cc View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-ideal.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-ideal.cc View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-real.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-real.cc View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
M src/lte/model/lte-rrc-sap.h View 1 2 12 chunks +66 lines, -59 lines 0 comments Download
M src/lte/model/lte-rrc-sap.cc View 1 2 2 chunks +22 lines, -1 line 0 comments Download
M src/lte/model/lte-spectrum-phy.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/model/lte-ue-cphy-sap.h View 1 2 6 chunks +126 lines, -38 lines 0 comments Download
M src/lte/model/lte-ue-net-device.h View 1 2 3 chunks +54 lines, -26 lines 0 comments Download
M src/lte/model/lte-ue-net-device.cc View 1 2 6 chunks +70 lines, -18 lines 0 comments Download
M src/lte/model/lte-ue-phy.h View 1 2 11 chunks +61 lines, -35 lines 0 comments Download
M src/lte/model/lte-ue-phy.cc View 1 2 25 chunks +230 lines, -134 lines 0 comments Download
M src/lte/model/lte-ue-rrc.h View 1 2 12 chunks +477 lines, -54 lines 0 comments Download
M src/lte/model/lte-ue-rrc.cc View 1 2 42 chunks +1667 lines, -493 lines 0 comments Download
A src/lte/model/no-op-handover-algorithm.h View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
A src/lte/model/no-op-handover-algorithm.cc View 1 2 1 chunk +97 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-cell-selection.h View 1 2 1 chunk +132 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-cell-selection.cc View 1 2 1 chunk +432 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-pathloss-model.cc View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
M src/lte/test/lte-test-phy-error-model.h View 1 2 3 chunks +27 lines, -17 lines 0 comments Download
M src/lte/test/lte-test-phy-error-model.cc View 1 2 10 chunks +140 lines, -86 lines 0 comments Download
M src/lte/test/lte-test-ue-measurements.h View 1 2 3 chunks +344 lines, -5 lines 0 comments Download
M src/lte/test/lte-test-ue-measurements.cc View 1 2 10 chunks +1718 lines, -44 lines 0 comments Download
M src/lte/test/lte-test-uplink-sinr.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A src/lte/test/test-lte-handover-target.cc View 1 2 1 chunk +434 lines, -0 lines 0 comments Download
M src/lte/test/test-lte-x2-handover.cc View 1 2 3 chunks +16 lines, -15 lines 0 comments Download
M src/lte/test/test-lte-x2-handover-measures.cc View 1 2 11 chunks +110 lines, -61 lines 0 comments Download
M src/lte/wscript View 1 2 3 chunks +16 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b