Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(246)

Issue 13722043: code review 13722043: go.tools/cmd/godoc: add redirect helpers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by adg
Modified:
6 years, 2 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

go.tools/cmd/godoc: add redirect helpers Previously these helpers were added by a private deployment script. There's no reason why they shouldn't be part of godoc proper now that it's in the go.tools repository.

Patch Set 1 #

Patch Set 2 : diff -r f080ec4c3156 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r f080ec4c3156 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M cmd/godoc/handlers.go View 1 2 4 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 8
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
6 years, 2 months ago (2013-09-16 01:21:12 UTC) #1
r
Why is it that, for example, tour.golang.org works yet golang.org/tour does not, yet issue.golang.org does ...
6 years, 2 months ago (2013-09-16 01:24:01 UTC) #2
adg
It's an artifact of how these things are hosted. For instance: golang.org/issue is a redirect ...
6 years, 2 months ago (2013-09-16 01:28:41 UTC) #3
r
The inconsistency bothers me. I always get it wrong. What is the rule? Not the ...
6 years, 2 months ago (2013-09-16 01:30:24 UTC) #4
adg
On 16 September 2013 11:30, Rob Pike <r@golang.org> wrote: > The inconsistency bothers me. I ...
6 years, 2 months ago (2013-09-16 01:36:35 UTC) #5
r
LGTM
6 years, 2 months ago (2013-09-16 01:38:49 UTC) #6
r
sounds good. thanks.
6 years, 2 months ago (2013-09-16 01:39:19 UTC) #7
adg
6 years, 2 months ago (2013-09-16 01:41:13 UTC) #8
*** Submitted as
https://code.google.com/p/go/source/detail?r=dc6035c8db3f&repo=tools ***

go.tools/cmd/godoc: add redirect helpers

Previously these helpers were added by a private deployment script.
There's no reason why they shouldn't be part of godoc proper now
that it's in the go.tools repository.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/13722043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b