Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 13718043: code review 13718043: runtime: fix CPU profiling on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rsc
Modified:
11 years, 7 months ago
Reviewers:
brainman
CC:
golang-dev
Visibility:
Public.

Description

runtime: fix CPU profiling on Windows The test 'gp == m->curg' is not valid on Windows, because the goroutine being profiled is not from the current m.

Patch Set 1 #

Patch Set 2 : diff -r 68c78b2f4018 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 68c78b2f4018 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/pkg/runtime/proc.c View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 7 months ago (2013-09-15 16:05:22 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=589bcd9dd528 *** runtime: fix CPU profiling on Windows The test 'gp == ...
11 years, 7 months ago (2013-09-15 16:05:28 UTC) #2
brainman
11 years, 7 months ago (2013-09-16 04:16:33 UTC) #3
Message was sent while issue was closed.
LGTM

Thank you.

Alex
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b