Issue 13715043: code review 13715043: fmt: %b for complex64 and complex128

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13715043: code review 13715043: fmt: %b for complex64 and complex128 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by r

Modified:
11 years, 6 months ago

Reviewers:
rsc

CC:
golang-dev, Dominik Honnef, rsc

Visibility:
Public.

Description

fmt: %b for complex64 and complex128 Just an oversight they were missing. Fixes issue 6387

Patch Set 1 #

Patch Set 2 : diff -r a6d1a3f0411a https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	src/pkg/fmt/fmt_test.go	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/pkg/fmt/format.go	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/pkg/fmt/print.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-14 22:30:56 UTC) #1

Dominik Honnef

Needs an update to vet as well then, which complains about %b in combination with ...

11 years, 6 months ago (2013-09-14 23:15:55 UTC) #2

No point in vet checking for something that hasn't happened yet. It's a different repo, ...

11 years, 6 months ago (2013-09-14 23:58:39 UTC) #3

Dominik Honnef

Sorry for the misunderstanding, didn't mean to suggest including that in this CL; just pointed ...

11 years, 6 months ago (2013-09-15 00:02:02 UTC) #4

11 years, 6 months ago (2013-09-15 00:45:45 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=3e162252c755 ***

fmt: %b for complex64 and complex128
Just an oversight they were missing.
Fixes issue 6387

R=golang-dev, dominik.honnef, rsc
CC=golang-dev
https://codereview.appspot.com/13715043

Expand All Messages | Collapse All Messages