Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 137120043: code review 137120043: runtime: give 2 words back in notetsleep_internal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
brainman, iant
CC:
golang-codereviews
Visibility:
Public.

Description

runtime: give 2 words back in notetsleep_internal I really hoped we could avoid this nonsense, but it appears not. Should fix windows/amd64 build breakage.

Patch Set 1 #

Patch Set 2 : diff -r b25fb560b4f01dda2ff89df365ec0b085725d734 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b25fb560b4f01dda2ff89df365ec0b085725d734 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/pkg/runtime/lock_sema.go View 1 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2014-09-04 03:10:13 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=23e48d4f3066 *** runtime: give 2 words back in notetsleep_internal I really hoped ...
10 years, 6 months ago (2014-09-04 03:10:23 UTC) #2
brainman
LGTM + // gp and deadline are logically local variables, but they are written + ...
10 years, 6 months ago (2014-09-04 03:46:31 UTC) #3
iant
10 years, 6 months ago (2014-09-04 03:56:35 UTC) #4
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b