Updated how unitName is sent to resolve/retry

Updated how unitName is sent to resolve/retry

The inspector was create an array[array] and thus passing the resovled()
method an array as a unitName. The go back end expects a string and it
refused to resolve/retry anything.

- Update the inspector method to make sure it grabs a single string
- Update the tests for the inspector to look for a single string
- Add a quick assertion in the go backend to fuss if it doesn't get a string


QA:

Note: MySQL always fails for me in my local lxc go environment

- Bootstrap a go environment in lxc, deploy mysql into it. I setup 3 units.
- Wait for the units to go into error state.
- Pick one of the units, resolve the unit.
- After a bit it should go to running and you can destroy it properly.
- Note that you can also watch the WS traffic in chrome dev tools and verify
that your request/response was successful. 

Example broken communication:

{"RequestId":31,"Error":"json: cannot unmarshal array into Go value of type string","Response":{}}
{"Type":"Client","Request":"Resolved","Params":{"UnitName":["mysql/0"],"Retry":false},"RequestId":32}

https://code.launchpad.net/~rharding/juju-gui/go-resolve-retry/+merge/185565

(do not edit description out of merge proposal)

[rharding, 2013-09-13 18:14:13]

Please take a look.

[benji, 2013-09-13 18:18:08]

LGTM, no QA.

https://codereview.appspot.com/13706043/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/13706043/diff/1/app/store/env/go.js#newcode1026
app/store/env/go.js:1026: }
If this is such a dire situation should we raise an exception too?

[rharding, 2013-09-13 18:21:33]

Replied

https://codereview.appspot.com/13706043/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/13706043/diff/1/app/store/env/go.js#newcode1026
app/store/env/go.js:1026: }
On 2013/09/13 18:18:08, benji wrote:
> If this is such a dire situation should we raise an exception too?

I think so. The API to go explicitly wants a string. So I'm going that a check
that it is a string is valid. 

I've tried to look at how to prevent the bug from happening in the future, and
this is the only thing I could think to do since resolve/retry is such a noop in
the sandbox/dev environment.

[benji, 2013-09-13 18:22:41]

On 2013/09/13 18:21:33, rharding wrote:
> Replied
> 
> https://codereview.appspot.com/13706043/diff/1/app/store/env/go.js
> File app/store/env/go.js (right):
> 
> https://codereview.appspot.com/13706043/diff/1/app/store/env/go.js#newcode1026
> app/store/env/go.js:1026: }
> On 2013/09/13 18:18:08, benji wrote:
> > If this is such a dire situation should we raise an exception too?
> 
> I think so. The API to go explicitly wants a string. So I'm going that a check
> that it is a string is valid. 
> 
> I've tried to look at how to prevent the bug from happening in the future, and
> this is the only thing I could think to do since resolve/retry is such a noop
in
> the sandbox/dev environment.

+1

[rharding, 2013-09-13 18:27:32]

*** Submitted:

Updated how unitName is sent to resolve/retry

The inspector was create an array[array] and thus passing the resovled()
method an array as a unitName. The go back end expects a string and it
refused to resolve/retry anything.

- Update the inspector method to make sure it grabs a single string
- Update the tests for the inspector to look for a single string
- Add a quick assertion in the go backend to fuss if it doesn't get a string


QA:

Note: MySQL always fails for me in my local lxc go environment

- Bootstrap a go environment in lxc, deploy mysql into it. I setup 3 units.
- Wait for the units to go into error state.
- Pick one of the units, resolve the unit.
- After a bit it should go to running and you can destroy it properly.
- Note that you can also watch the WS traffic in chrome dev tools and verify
that your request/response was successful. 

Example broken communication:

{"RequestId":31,"Error":"json: cannot unmarshal array into Go value of type
string","Response":{}}
{"Type":"Client","Request":"Resolved","Params":{"UnitName":["mysql/0"],"Retry":false},"RequestId":32}

R=benji
CC=
https://codereview.appspot.com/13706043