Charm updated notification

Charm updated notification

This adds a notification to the inspector when a charm has been changed for a service.

To QA:

1. Deploy a service
2. Open the inspector
3. Open the javascript console, and type:

   app.db.services.item(0).set('charmChanged', true);

4. The notification should appear below the service header

https://code.launchpad.net/~makyo/juju-gui/upgrade-notification/+merge/187252

(do not edit description out of merge proposal)

[matthew.scott, 2013-09-24 14:32:16]

Please take a look.

[matthew.scott, 2013-09-24 14:35:46]

QA note: use /:flags:/upgradeCharm

[jeff.pihach, 2013-09-24 14:44:44]

When I don't use the flag it works as expected. Using the flag causes it to
display a number of errors in the console

Uncaught TypeError: Cannot read property 'offsetHeight' of null (in d3)

I'm also curious about the 'hiding story' right now the user can only ever
upgrade once per application reload

https://codereview.appspot.com/13705045/diff/1/app/templates/inspector-header...
File app/templates/inspector-header.handlebars (right):

https://codereview.appspot.com/13705045/diff/1/app/templates/inspector-header...
app/templates/inspector-header.handlebars:24: {{#unless ghost}}
The only way to dismiss this is to close and re-open the inspector. Is the
future plan to move this into a notification? 

Maybe in the meantime we have this fade out after 5s or so?

https://codereview.appspot.com/13705045/diff/1/app/views/viewlets/inspector-h...
File app/views/viewlets/inspector-header.js (right):

https://codereview.appspot.com/13705045/diff/1/app/views/viewlets/inspector-h...
app/views/viewlets/inspector-header.js:33: charmChanged: {
Does Juju set this to 'false' at some point hiding the element and allowing the
user to upgrade again?

[matthew.scott, 2013-09-24 20:06:48]

Please take a look.

[jeff.pihach, 2013-09-24 20:21:48]

LGTM Thanks for the fixes!

[jeff.pihach, 2013-09-24 20:22:03]

QA OK

[matthew.scott, 2013-09-24 22:35:40]

*** Submitted:

Charm updated notification

This adds a notification to the inspector when a charm has been changed for a
service.

To QA:

1. Deploy a service
2. Open the inspector
3. Open the javascript console, and type:

   app.db.services.item(0).set('charmChanged', true);

4. The notification should appear below the service header

R=jeff.pihach
CC=
https://codereview.appspot.com/13705045