code review 13698043: cmd/gc: don't generate algs for internal map types.

cmd/gc: don't generate algs for internal map types.

Fake types describing the internal structure of hashmaps are
generated for use by precise GC.

Generating hash and eq functions for these fake types slows down
the build and wastes space: the go tool binary size is 13MB
instead of 12MB, and the package size on amd64 is 48.7MB instead
of 45.3MB.

[remyoudompheng, 2013-09-13 10:47:01]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[DMorsing, 2013-09-13 10:54:21]

LGTM.

[remyoudompheng, 2013-09-13 22:43:15]

Is this ok to commit for Go 1.2 ? I consider it a regression w.r.t. binary size.

[r, 2013-09-13 22:47:10]

LGTM from my end but get approval from rsc and iant as well.

binary size is a bugaboo of mine at the moment.

[khr1, 2013-09-13 23:24:44]

LGTM.



On Fri, Sep 13, 2013 at 3:47 PM, <r@golang.org> wrote:

> LGTM from my end but get approval from rsc and iant as well.
>
> binary size is a bugaboo of mine at the moment.
>
>
>
https://codereview.appspot.**com/13698043/<https://codereview.appspot.com/136...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[rsc, 2013-09-13 23:44:56]

LGTM

[iant, 2013-09-14 00:13:06]

LGTM

[remyoudompheng, 2013-09-14 07:30:40]

*** Submitted as https://code.google.com/p/go/source/detail?r=a6d1a3f0411a ***

cmd/gc: don't generate algs for internal map types.

Fake types describing the internal structure of hashmaps are
generated for use by precise GC.

Generating hash and eq functions for these fake types slows down
the build and wastes space: the go tool binary size is 13MB
instead of 12MB, and the package size on amd64 is 48.7MB instead
of 45.3MB.

R=golang-dev, daniel.morsing, r, khr, rsc, iant
CC=golang-dev
https://codereview.appspot.com/13698043