Issue 13696043: cmd/jujud: avoid using allFatal

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13696043: cmd/jujud: avoid using allFatal

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
dimitern, fwereade, mp+185445

Visibility:
Public.

Description

cmd/jujud: avoid using allFatal This is a backport of the https://code.launchpad.net/~rogpeppe/juju-core/384-avoid-allfatal/+merge/184743 now proposed for 1.14, with selected other patches from other revisions to make it compile. https://code.launchpad.net/~rogpeppe/juju-core/391-1.14-avoid-allFatal/+merge/185445 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: avoid using allFatal #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+315 lines, -65 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/agent.go	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	cmd/jujud/agent_test.go	View	2 chunks	+66 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	6 chunks	+14 lines, -8 lines	0 comments	Download
M	cmd/jujud/machine_test.go	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	cmd/jujud/unit.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	juju/testing/conn.go	View	9 chunks	+48 lines, -36 lines	0 comments	Download
M	state/api/apiclient.go	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	state/apiserver/pinger_test.go	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	state/state.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	state/state_test.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	testing/checkers/set.go	View	1 chunk	+35 lines, -0 lines	0 comments	Download
A	testing/checkers/set_test.go	View	1 chunk	+54 lines, -0 lines	0 comments	Download
M	testing/mgo.go	View	3 chunks	+38 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages